Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: content/browser/frame_host/navigation_controller_impl.h

Issue 2376643002: Clean up NavigationControllerImpl::IsURLInPageNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up NavigationControllerImpl::IsURLInPageNavigation Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « AUTHORS ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 // If a new entry is created, it will return true and will have filled the 142 // If a new entry is created, it will return true and will have filled the
143 // given details structure and broadcast the NOTIFY_NAV_ENTRY_COMMITTED 143 // given details structure and broadcast the NOTIFY_NAV_ENTRY_COMMITTED
144 // notification. The caller can then use the details without worrying about 144 // notification. The caller can then use the details without worrying about
145 // listening for the notification. 145 // listening for the notification.
146 // 146 //
147 // In the case that nothing has changed, the details structure is undefined 147 // In the case that nothing has changed, the details structure is undefined
148 // and it will return false. 148 // and it will return false.
149 bool RendererDidNavigate( 149 bool RendererDidNavigate(
150 RenderFrameHostImpl* rfh, 150 RenderFrameHostImpl* rfh,
151 const FrameHostMsg_DidCommitProvisionalLoad_Params& params, 151 const FrameHostMsg_DidCommitProvisionalLoad_Params& params,
152 LoadCommittedDetails* details); 152 LoadCommittedDetails* details,
153 bool is_navigation_within_page);
153 154
154 // Notifies us that we just became active. This is used by the WebContentsImpl 155 // Notifies us that we just became active. This is used by the WebContentsImpl
155 // so that we know to load URLs that were pending as "lazy" loads. 156 // so that we know to load URLs that were pending as "lazy" loads.
156 void SetActive(bool is_active); 157 void SetActive(bool is_active);
157 158
158 // Returns true if the given URL would be an in-page navigation (e.g., if the 159 // Returns true if the given URL would be an in-page navigation (e.g., if the
159 // reference fragment is different, or after a pushState) from the last 160 // reference fragment is different, or after a pushState) from the last
160 // committed URL in the specified frame. If there is no last committed entry, 161 // committed URL in the specified frame. If there is no last committed entry,
161 // then nothing will be in-page. 162 // then nothing will be in-page.
162 // 163 //
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 TimeSmoother time_smoother_; 450 TimeSmoother time_smoother_;
450 451
451 std::unique_ptr<NavigationEntryScreenshotManager> screenshot_manager_; 452 std::unique_ptr<NavigationEntryScreenshotManager> screenshot_manager_;
452 453
453 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl); 454 DISALLOW_COPY_AND_ASSIGN(NavigationControllerImpl);
454 }; 455 };
455 456
456 } // namespace content 457 } // namespace content
457 458
458 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_ 459 #endif // CONTENT_BROWSER_FRAME_HOST_NAVIGATION_CONTROLLER_IMPL_H_
OLDNEW
« no previous file with comments | « AUTHORS ('k') | content/browser/frame_host/navigation_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698