Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2376633003: Update style of media controls popup. (Closed)

Created:
4 years, 2 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 2 months ago
Reviewers:
foolip
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, rwlbuis, nessy, Srirama, vcarbune.chromium
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update style of media controls popup. This is: - changing the position of the popup. - adding round corner. - adding a shadow. It applies to both the overflow and CC menu. BUG=651417 Committed: https://crrev.com/62fa917d17ee2358ab4c9c747318eafa897400e7 Cr-Commit-Position: refs/heads/master@{#422319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M third_party/WebKit/Source/core/css/mediaControlsNew.css View 2 chunks +4 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
mlamouri (slow - plz ping)
4 years, 2 months ago (2016-09-27 15:29:26 UTC) #2
foolip
lgtm I think, but if you update test expectations it's easier to see how this ...
4 years, 2 months ago (2016-09-28 14:24:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376633003/1
4 years, 2 months ago (2016-10-01 14:43:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-01 15:33:25 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 15:35:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62fa917d17ee2358ab4c9c747318eafa897400e7
Cr-Commit-Position: refs/heads/master@{#422319}

Powered by Google App Engine
This is Rietveld 408576698