Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2376633002: Small cleanup in SearchTabHelper (Closed)

Created:
4 years, 2 months ago by Marc Treib
Modified:
4 years ago
Reviewers:
sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Small cleanup in SearchTabHelper Remove SearchTabHelper::SupportsInstant - it's only used by tests, so move it into the test. BUG=627747 Committed: https://crrev.com/89075d4cbd441f51ff1c38884be566fba1822ca9 Cr-Commit-Position: refs/heads/master@{#437238}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -28 lines) Patch
M chrome/browser/ui/search/instant_tab_unittest.cc View 1 5 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper.h View 1 4 chunks +0 lines, -8 lines 2 comments Download
M chrome/browser/ui/search/search_tab_helper.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
Marc Treib
PTAL!
4 years ago (2016-12-08 13:03:29 UTC) #7
sfiera
LGTM https://codereview.chromium.org/2376633002/diff/20001/chrome/browser/ui/search/search_tab_helper.h File chrome/browser/ui/search/search_tab_helper.h (left): https://codereview.chromium.org/2376633002/diff/20001/chrome/browser/ui/search/search_tab_helper.h#oldcode10 chrome/browser/ui/search/search_tab_helper.h:10: #include "base/compiler_specific.h" wut
4 years ago (2016-12-08 13:12:38 UTC) #8
Marc Treib
https://codereview.chromium.org/2376633002/diff/20001/chrome/browser/ui/search/search_tab_helper.h File chrome/browser/ui/search/search_tab_helper.h (left): https://codereview.chromium.org/2376633002/diff/20001/chrome/browser/ui/search/search_tab_helper.h#oldcode10 chrome/browser/ui/search/search_tab_helper.h:10: #include "base/compiler_specific.h" On 2016/12/08 13:12:37, sfiera wrote: > wut ...
4 years ago (2016-12-08 13:15:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376633002/20001
4 years ago (2016-12-08 14:00:12 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 14:04:35 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-08 14:06:34 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89075d4cbd441f51ff1c38884be566fba1822ca9
Cr-Commit-Position: refs/heads/master@{#437238}

Powered by Google App Engine
This is Rietveld 408576698