Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2376613004: Add use counters for SVGCursorElement (Closed)

Created:
4 years, 2 months ago by fs
Modified:
4 years, 2 months ago
Reviewers:
pdr., Ilya Sherman, foolip
CC:
fs, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add use counters for SVGCursorElement This adds one counter for presence of an SVGCursorElement, and one for if any ComputedStyle references the element (==the SVGCursorElement has a client.) BUG=650598 Committed: https://crrev.com/2ee169bbba95ad27368dc8d275b5744335582e47 Cr-Commit-Position: refs/heads/master@{#421630}

Patch Set 1 #

Patch Set 2 : Add test #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/svg/css/svgcursorelement-use-counter.html View 1 1 chunk +35 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGCursorElement.cpp View 3 chunks +5 lines, -0 lines 2 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
fs
4 years, 2 months ago (2016-09-28 14:45:19 UTC) #4
foolip
lgtm https://codereview.chromium.org/2376613004/diff/20001/third_party/WebKit/Source/core/svg/SVGCursorElement.cpp File third_party/WebKit/Source/core/svg/SVGCursorElement.cpp (right): https://codereview.chromium.org/2376613004/diff/20001/third_party/WebKit/Source/core/svg/SVGCursorElement.cpp#newcode50 third_party/WebKit/Source/core/svg/SVGCursorElement.cpp:50: UseCounter::count(document(), UseCounter::SVGCursorElementHasClient); If this is not reach, the ...
4 years, 2 months ago (2016-09-28 14:57:01 UTC) #5
fs
https://codereview.chromium.org/2376613004/diff/20001/third_party/WebKit/Source/core/svg/SVGCursorElement.cpp File third_party/WebKit/Source/core/svg/SVGCursorElement.cpp (right): https://codereview.chromium.org/2376613004/diff/20001/third_party/WebKit/Source/core/svg/SVGCursorElement.cpp#newcode50 third_party/WebKit/Source/core/svg/SVGCursorElement.cpp:50: UseCounter::count(document(), UseCounter::SVGCursorElementHasClient); On 2016/09/28 at 14:57:01, foolip wrote: > ...
4 years, 2 months ago (2016-09-28 15:03:02 UTC) #6
Ilya Sherman
histograms.xml lgtm
4 years, 2 months ago (2016-09-28 20:04:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376613004/20001
4 years, 2 months ago (2016-09-28 20:29:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 20:35:58 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:39:49 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ee169bbba95ad27368dc8d275b5744335582e47
Cr-Commit-Position: refs/heads/master@{#421630}

Powered by Google App Engine
This is Rietveld 408576698