Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2376613003: [promises] Use PromiseCreate when applicable (Closed)

Created:
4 years, 2 months ago by gsathya
Modified:
4 years, 2 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Use PromiseCreate when applicable Committed: https://crrev.com/34a0ac3ccaef1947fc410437b0aa421dc2502d11 Cr-Commit-Position: refs/heads/master@{#40011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/js/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
gsathya
4 years, 2 months ago (2016-09-27 19:23:27 UTC) #4
gsathya
ping
4 years, 2 months ago (2016-10-04 18:45:35 UTC) #7
adamk
lgtm
4 years, 2 months ago (2016-10-04 18:51:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376613003/1
4 years, 2 months ago (2016-10-05 18:45:54 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 19:43:52 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 19:44:15 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34a0ac3ccaef1947fc410437b0aa421dc2502d11
Cr-Commit-Position: refs/heads/master@{#40011}

Powered by Google App Engine
This is Rietveld 408576698