Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2376613002: MD History: Replace tap listeners with click listeners for icon-button-light (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Replace tap listeners with click listeners for icon-button-light This is a workaround for https://github.com/Polymer/polymer/issues/4002, which prevents touch events from firing on paper-icon-button-light when it is lazily upgraded. BUG=650551 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/a3cc58bff64f44d1774fa9a2db95c422eef1f8cd Cr-Commit-Position: refs/heads/master@{#421430}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/resources/md_history/app.vulcanized.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_history/history_item.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_history/history_toolbar.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
tsergeant
4 years, 2 months ago (2016-09-27 07:31:18 UTC) #5
calamity
lgtm
4 years, 2 months ago (2016-09-28 02:38:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376613002/1
4 years, 2 months ago (2016-09-28 02:38:18 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 02:43:41 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 02:45:41 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3cc58bff64f44d1774fa9a2db95c422eef1f8cd
Cr-Commit-Position: refs/heads/master@{#421430}

Powered by Google App Engine
This is Rietveld 408576698