Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 23766034: Add toRenderSVGResourceRadialGradient() fuction, and use it. (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive
Modified:
7 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, f(malita), jchaffraix+rendering, pdr, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add toRenderSVGResourceRadialGradient() fuction, and use it. This function has type checking assertions for helping to find bad-cast bugs. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M Source/core/rendering/svg/RenderSVGResourceRadialGradient.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent to reviewer.
7 years, 3 months ago (2013-09-14 23:08:24 UTC) #1
tkent
lgtm
7 years, 3 months ago (2013-09-16 22:07:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23766034/1
7 years, 3 months ago (2013-09-16 22:07:40 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 00:13:21 UTC) #4
Message was sent while issue was closed.
Change committed as 157867

Powered by Google App Engine
This is Rietveld 408576698