Source/core/svg/SVGAltGlyphDefElement.cpp - Issue 23766031: Add toSVGGlyphRefElement(), and use it as much as possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGAltGlyphDefElement.cpp

Issue 23766031: Add toSVGGlyphRefElement(), and use it as much as possible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGAltGlyphDefElement.cpp

diff --git a/Source/core/svg/SVGAltGlyphDefElement.cpp b/Source/core/svg/SVGAltGlyphDefElement.cpp

index b6320872f21d7768130fefd11d8441520079ae3c..d99b1656aac38f7f94640a86d249e4e034477b10 100644

--- a/Source/core/svg/SVGAltGlyphDefElement.cpp

+++ b/Source/core/svg/SVGAltGlyphDefElement.cpp

@@ -94,7 +94,7 @@ bool SVGAltGlyphDefElement::hasValidGlyphElements(Vector<String>& glyphNames) co

fountFirstGlyphRef = true;

String referredGlyphName;

- if (static_cast<SVGGlyphRefElement*>(child)->hasValidGlyphElement(referredGlyphName))

+ if (toSVGGlyphRefElement(child)->hasValidGlyphElement(referredGlyphName))

glyphNames.append(referredGlyphName);

else {

// As the spec says "If any of the referenced glyphs are unavailable,

« no previous file with comments | « no previous file | Source/core/svg/SVGAltGlyphItemElement.cpp » ('j') | no next file with comments »