Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Side by Side Diff: Source/core/svg/SVGAltGlyphItemElement.cpp

Issue 23766031: Add toSVGGlyphRefElement(), and use it as much as possible (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/svg/SVGAltGlyphDefElement.cpp ('k') | Source/core/svg/SVGGlyphRefElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Leo Yang <leoyang@webkit.org> 2 * Copyright (C) 2011 Leo Yang <leoyang@webkit.org>
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 // The ‘altGlyphItem’ element defines a candidate set of possible glyph subs titutions. 45 // The ‘altGlyphItem’ element defines a candidate set of possible glyph subs titutions.
46 // The first ‘altGlyphItem’ element whose referenced glyphs are all availabl e is chosen. 46 // The first ‘altGlyphItem’ element whose referenced glyphs are all availabl e is chosen.
47 // Its glyphs are rendered instead of the character(s) that are inside of th e referencing 47 // Its glyphs are rendered instead of the character(s) that are inside of th e referencing
48 // ‘altGlyph’ element. 48 // ‘altGlyph’ element.
49 // 49 //
50 // Here we fill glyphNames and return true only if all referenced glyphs are valid and 50 // Here we fill glyphNames and return true only if all referenced glyphs are valid and
51 // there is at least one glyph. 51 // there is at least one glyph.
52 for (Node* child = firstChild(); child; child = child->nextSibling()) { 52 for (Node* child = firstChild(); child; child = child->nextSibling()) {
53 if (child->hasTagName(SVGNames::glyphRefTag)) { 53 if (child->hasTagName(SVGNames::glyphRefTag)) {
54 String referredGlyphName; 54 String referredGlyphName;
55 if (static_cast<SVGGlyphRefElement*>(child)->hasValidGlyphElement(re ferredGlyphName)) 55 if (toSVGGlyphRefElement(child)->hasValidGlyphElement(referredGlyphN ame))
56 glyphNames.append(referredGlyphName); 56 glyphNames.append(referredGlyphName);
57 else { 57 else {
58 glyphNames.clear(); 58 glyphNames.clear();
59 return false; 59 return false;
60 } 60 }
61 } 61 }
62 } 62 }
63 return !glyphNames.isEmpty(); 63 return !glyphNames.isEmpty();
64 } 64 }
65 65
66 } 66 }
67 67
68 #endif 68 #endif
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAltGlyphDefElement.cpp ('k') | Source/core/svg/SVGGlyphRefElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698