Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 23766031: Add toSVGGlyphRefElement(), and use it as much as possible (Closed)

Created:
7 years, 3 months ago by gyuyoung-inactive
Modified:
7 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr, eae+blinkwatch, Stephen Chennney, f(malita), dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add toSVGGlyphRefElement(), and use it as much as possible This function will help to cast with type checking assertions in order to detect bad-cast bugs. BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157729

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M Source/core/svg/SVGAltGlyphDefElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAltGlyphItemElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGGlyphRefElement.h View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
gyuyoung-inactive
Add tkent.
7 years, 3 months ago (2013-09-12 12:56:51 UTC) #1
tkent
lgtm
7 years, 3 months ago (2013-09-12 22:41:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gyuyoung.kim@samsung.com/23766031/1
7 years, 3 months ago (2013-09-12 22:41:47 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 02:15:45 UTC) #4
Message was sent while issue was closed.
Change committed as 157729

Powered by Google App Engine
This is Rietveld 408576698