Add checks that ensure flash isn't exposed to a page if an enterprise ASK setting is in effect

Add checks that ensure flash isn't exposed to a page if an enterprise ASK setting is in effect

Currently site engagement can be used to detect if flash should be exposed to a
website. But enterprises need predictable control over when flash will run.
This change ensure that site engagement won't be used to expose flash if an
enterprise ask setting is in effect.

BUG=649812
Committed: https://crrev.com/e9d8a656f2183534de734e483d42e37d2d3575da
Cr-Commit-Position: refs/heads/master@{#421421}

[raymes, 2016-09-27 06:06:04]

raymes@chromium.org changed reviewers:
+ bauerb@chromium.org, tommycli@chromium.org

[Bernhard Bauer, 2016-09-27 09:35:57]

lgtm

[tommycli, 2016-09-27 16:42:59]

LGTM Thank you!

https://codereview.chromium.org/2376603002/diff/1/chrome/browser/plugins/chro...
File chrome/browser/plugins/chrome_plugin_service_filter.cc (right):

https://codereview.chromium.org/2376603002/diff/1/chrome/browser/plugins/chro...
chrome/browser/plugins/chrome_plugin_service_filter.cc:229: is_managed) {
nit: Since is_managed is so much cheaper than the other call, put that first?

[raymes, 2016-09-28 00:40:10]

https://codereview.chromium.org/2376603002/diff/1/chrome/browser/plugins/chro...
File chrome/browser/plugins/chrome_plugin_service_filter.cc (right):

https://codereview.chromium.org/2376603002/diff/1/chrome/browser/plugins/chro...
chrome/browser/plugins/chrome_plugin_service_filter.cc:229: is_managed) {
On 2016/09/27 16:42:59, tommycli wrote:
> nit: Since is_managed is so much cheaper than the other call, put that first?

Done.

[raymes, 2016-09-28 00:40:14]

The CQ bit was checked by raymes@chromium.org

[raymes, 2016-09-28 00:40:15]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2376603002/#ps20001
(title: "Add checks that ensure flash isn't exposed to a page if an enterprise
ASK setting is in effect")

[commit-bot: I haz the power, 2016-09-28 00:40:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 01:33:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 01:37:18]

Description was changed from

==========
Add checks that ensure flash isn't exposed to a page if an enterprise ASK
setting is in effect

Currently site engagement can be used to detect if flash should be exposed to a
website. But enterprises need predictable control over when flash will run.
This change ensure that site engagement won't be used to expose flash if an
enterprise ask setting is in effect.

BUG=649812
==========

to

==========
Add checks that ensure flash isn't exposed to a page if an enterprise ASK
setting is in effect

Currently site engagement can be used to detect if flash should be exposed to a
website. But enterprises need predictable control over when flash will run.
This change ensure that site engagement won't be used to expose flash if an
enterprise ask setting is in effect.

BUG=649812

Committed: https://crrev.com/e9d8a656f2183534de734e483d42e37d2d3575da
Cr-Commit-Position: refs/heads/master@{#421421}
==========

[commit-bot: I haz the power, 2016-09-28 01:37:19]

Patchset 2 (id:??) landed as
https://crrev.com/e9d8a656f2183534de734e483d42e37d2d3575da
Cr-Commit-Position: refs/heads/master@{#421421}