Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Unified Diff: tests/corelib/uri_ipv6_test.dart

Issue 23766030: Return the correct port from Uri, when port is 0 and scheme is either http or https. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix test. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/corelib/uri_ipv6_test.dart
diff --git a/tests/corelib/uri_ipv6_test.dart b/tests/corelib/uri_ipv6_test.dart
index c5f105f7101c6e7a1cf3788752efdc7f717c97c3..0f3ba037ff9cffaf58b1adb2d1e379e1ce2b8295 100644
--- a/tests/corelib/uri_ipv6_test.dart
+++ b/tests/corelib/uri_ipv6_test.dart
@@ -28,7 +28,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('http', uri.scheme);
Expect.equals('FEDC:BA98:7654:3210:FEDC:BA98:7654:3210', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(80, uri.port);
Expect.equals('/index.html', uri.path);
Expect.equals('http://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]/index.html',
uri.toString());
@@ -37,7 +37,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('https', uri.scheme);
Expect.equals('FEDC:BA98:7654:3210:FEDC:BA98:7654:3210', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(443, uri.port);
Expect.equals('/index.html', uri.path);
Expect.equals('https://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]/index.html',
uri.toString());
@@ -46,7 +46,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('http', uri.scheme);
Expect.equals('1080:0:0:0:8:800:200C:417A', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(80, uri.port);
Expect.equals('/index.html', uri.path);
Expect.equals(path, uri.toString());
@@ -54,7 +54,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('http', uri.scheme);
Expect.equals('3ffe:2a00:100:7031::1', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(80, uri.port);
Expect.equals('', uri.path);
Expect.equals(path, uri.toString());
@@ -62,7 +62,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('http', uri.scheme);
Expect.equals('1080::8:800:200C:417A', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(80, uri.port);
Expect.equals('/foo', uri.path);
Expect.equals(path, uri.toString());
@@ -70,7 +70,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('http', uri.scheme);
Expect.equals('::192.9.5.5', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(80, uri.port);
Expect.equals('/ipng', uri.path);
Expect.equals(path, uri.toString());
@@ -86,7 +86,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('http', uri.scheme);
Expect.equals('::FFFF:129.144.52.38', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(80, uri.port);
Expect.equals('/index.html', uri.path);
Expect.equals('http://[::FFFF:129.144.52.38]/index.html', uri.toString());
@@ -94,7 +94,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('https', uri.scheme);
Expect.equals('::FFFF:129.144.52.38', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(443, uri.port);
Expect.equals('/index.html', uri.path);
Expect.equals('https://[::FFFF:129.144.52.38]/index.html', uri.toString());
@@ -102,7 +102,7 @@ void testValidIpv6Uri() {
uri = Uri.parse(path);
Expect.equals('http', uri.scheme);
Expect.equals('2010:836B:4179::836B:4179', uri.host);
- Expect.equals(0, uri.port);
+ Expect.equals(80, uri.port);
Expect.equals('', uri.path);
Expect.equals(path, uri.toString());
}

Powered by Google App Engine
This is Rietveld 408576698