Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Issue 23766029: Files.app: Let the file browser private filesystem APIs use the auto-generated helper classes. (Closed)

Created:
7 years, 3 months ago by hirono
Modified:
7 years, 3 months ago
Reviewers:
kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app: Let the file browser private filesystem APIs use the auto-generated helper classes. Originally, the file browser private filesystem APIs parse the arguments and generate the results manually. This CL lets the APIs use the auto generated helper classes to parse the arguments. BUG=241693 TEST=file_manager_browsertests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=223534

Patch Set 1 #

Total comments: 3

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -168 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.h View 11 chunks +11 lines, -34 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 11 chunks +22 lines, -134 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hirono
Could you take a look the CL? Thank you very much!
7 years, 3 months ago (2013-09-12 07:04:12 UTC) #1
kinaba
https://codereview.chromium.org/23766029/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc (right): https://codereview.chromium.org/23766029/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc#newcode464 chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc:464: render_view_host(), profile(), GURL(params->mount_path)); This parameter should be URL. Could ...
7 years, 3 months ago (2013-09-12 07:34:18 UTC) #2
hirono
Thanks! https://codereview.chromium.org/23766029/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc (right): https://codereview.chromium.org/23766029/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc#newcode464 chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc:464: render_view_host(), profile(), GURL(params->mount_path)); On 2013/09/12 07:34:19, kinaba wrote: ...
7 years, 3 months ago (2013-09-17 01:21:19 UTC) #3
kinaba
On 2013/09/17 01:21:19, hirono wrote: > Thanks! > > https://codereview.chromium.org/23766029/diff/1/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc > File chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc > (right): ...
7 years, 3 months ago (2013-09-17 01:44:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23766029/10001
7 years, 3 months ago (2013-09-17 01:49:18 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 3 months ago (2013-09-17 01:56:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/23766029/10001
7 years, 3 months ago (2013-09-17 02:01:05 UTC) #7
commit-bot: I haz the power
7 years, 3 months ago (2013-09-17 04:13:00 UTC) #8
Message was sent while issue was closed.
Change committed as 223534

Powered by Google App Engine
This is Rietveld 408576698