Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 23766011: Revert 221380 "Use Finch to compare the performances of CLD1 and..." (Closed)

Created:
7 years, 3 months ago by pneubeck (no reviews)
Modified:
7 years, 3 months ago
Reviewers:
hajimehoshi
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 221380 "Use Finch to compare the performances of CLD1 and..." Broke http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=ChromiumOS%20%28daisy%29&number=12452 and maybe http://build.chromium.org/p/chromium/buildstatus?builder=Linux%20x64&number=55236 http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder&number=9603 > Use Finch to compare the performances of CLD1 and CLD2 > > Add a compile time constant CLD_VERSION, which indicates the version of CLD. If this is not define, Finch test to compare CLD1 and CLD2 is supposed to be used. > > By this CL, each platform will have the below status: > > Linux: Use both CLD1 and CLD2 (and use Finch). > Mac OS X: Use both CLD1 and CLD2 (and use Finch). > Windows: Use only CLD1 once because now CLD2 can't be compiled on Windows. After we can have CLD2 compiled on Windows, we will use CLD2 and Finch asap. > iOS: Still use only CLD1. (It's because it is hard to use both CLD1 and CLD2 on mobile platform because of the binary size impact.) > Android: Still use only CLD1. (The same reason as iOS) > > So some platforms will have two CLD binaries, but this is temporal in the sense that we intend to use Finch only for Dev and Beta channel. Before releasing the stable Chromium version, we decide which version of CLD is adopted, make another CL to use only one CLD, and send a merge request. (Of course, we hope we will be able to adopt CLD2.) > > BUG=240647 > > Review URL: https://chromiumcodereview.appspot.com/22867032 TBR=hajimehoshi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -432 lines) Patch
M trunk/src/build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/build/common.gypi View 5 chunks +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/chrome_common.gypi View 2 chunks +1 line, -10 lines 0 comments Download
M trunk/src/chrome/chrome_dll.gypi View 2 chunks +1 line, -10 lines 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 4 chunks +10 lines, -16 lines 0 comments Download
M trunk/src/chrome/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/common/translate/language_detection_util.cc View 4 chunks +8 lines, -92 lines 0 comments Download
M trunk/src/third_party/cld/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
D trunk/src/third_party/cld_2/LICENSE View 1 chunk +0 lines, -202 lines 0 comments Download
D trunk/src/third_party/cld_2/OWNERS View 1 chunk +0 lines, -3 lines 0 comments Download
D trunk/src/third_party/cld_2/README.chromium View 1 chunk +0 lines, -10 lines 0 comments Download
D trunk/src/third_party/cld_2/cld_2.gyp View 1 chunk +0 lines, -71 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pneubeck (no reviews)
7 years, 3 months ago (2013-09-05 11:54:41 UTC) #1
pneubeck (no reviews)
7 years, 3 months ago (2013-09-05 11:54:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r221391.

Powered by Google App Engine
This is Rietveld 408576698