Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: tools/perf/measurements/smoothness.py

Issue 23766009: Telemetry: smoothness measurement throws MissingTimelineMarker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/smoothness.py
diff --git a/tools/perf/measurements/smoothness.py b/tools/perf/measurements/smoothness.py
index 47a7802b7af51579fa5a3a4b95b17da47f804739..b257e78ac229f1fb4f19754106bd5a2ecee76402 100644
--- a/tools/perf/measurements/smoothness.py
+++ b/tools/perf/measurements/smoothness.py
@@ -15,6 +15,10 @@ class MissingDisplayFrameRate(page_measurement.MeasurementFailure):
super(MissingDisplayFrameRate, self).__init__(
'Missing display frame rate metrics: ' + name)
bulach 2013/09/05 10:30:33 ultra nit: not your fault, but there should be two
+class MissingTimelineMarker(page_measurement.MeasurementFailure):
+ def __init__(self):
+ super(MissingTimelineMarker, self).__init__('Timeline marker not found')
+
class Smoothness(page_measurement.PageMeasurement):
def __init__(self):
super(Smoothness, self).__init__('smoothness')
@@ -57,7 +61,7 @@ class Smoothness(page_measurement.PageMeasurement):
smoothness.TIMELINE_MARKER)
if s.parent_slice == None]
if len(events) != 1:
- raise LookupError, 'timeline marker not found'
+ raise MissingTimelineMarker()
return events[0]
def MeasurePage(self, page, tab, results):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698