Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Side by Side Diff: src/api.cc

Issue 23766003: Handlify JSObject::DeleteElement method. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3553 matching lines...) Expand 10 before | Expand all | Expand 10 after
3564 } 3564 }
3565 3565
3566 3566
3567 bool v8::Object::Delete(uint32_t index) { 3567 bool v8::Object::Delete(uint32_t index) {
3568 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3568 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3569 ON_BAILOUT(isolate, "v8::Object::DeleteProperty()", 3569 ON_BAILOUT(isolate, "v8::Object::DeleteProperty()",
3570 return false); 3570 return false);
3571 ENTER_V8(isolate); 3571 ENTER_V8(isolate);
3572 HandleScope scope(reinterpret_cast<Isolate*>(isolate)); 3572 HandleScope scope(reinterpret_cast<Isolate*>(isolate));
3573 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3573 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3574 return i::JSObject::DeleteElement(self, index)->IsTrue(); 3574 return i::JSReceiver::DeleteElement(self, index)->IsTrue();
3575 } 3575 }
3576 3576
3577 3577
3578 bool v8::Object::Has(uint32_t index) { 3578 bool v8::Object::Has(uint32_t index) {
3579 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate(); 3579 i::Isolate* isolate = Utils::OpenHandle(this)->GetIsolate();
3580 ON_BAILOUT(isolate, "v8::Object::HasProperty()", return false); 3580 ON_BAILOUT(isolate, "v8::Object::HasProperty()", return false);
3581 i::Handle<i::JSObject> self = Utils::OpenHandle(this); 3581 i::Handle<i::JSObject> self = Utils::OpenHandle(this);
3582 return self->HasElement(index); 3582 return self->HasElement(index);
3583 } 3583 }
3584 3584
(...skipping 4261 matching lines...) Expand 10 before | Expand all | Expand 10 after
7846 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate()); 7846 Isolate* isolate = reinterpret_cast<Isolate*>(info.GetIsolate());
7847 Address callback_address = 7847 Address callback_address =
7848 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback)); 7848 reinterpret_cast<Address>(reinterpret_cast<intptr_t>(callback));
7849 VMState<EXTERNAL> state(isolate); 7849 VMState<EXTERNAL> state(isolate);
7850 ExternalCallbackScope call_scope(isolate, callback_address); 7850 ExternalCallbackScope call_scope(isolate, callback_address);
7851 return callback(info); 7851 return callback(info);
7852 } 7852 }
7853 7853
7854 7854
7855 } } // namespace v8::internal 7855 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698