Limit scope getter to predefined values

third_party/WebKit/Source/core/html/HTMLTableCellElement.cpp

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2010 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 156 matching lines @@
     return fastGetAttribute(headersAttr);
 }
 
 void HTMLTableCellElement::setRowSpan(unsigned n)
 {
     setUnsignedIntegralAttribute(rowspanAttr, n);
 }
 
 const AtomicString& HTMLTableCellElement::scope() const
 {
-    return fastGetAttribute(scopeAttr);
+    const AtomicString& scopeValue = fastGetAttribute(scopeAttr);
+    if (equalIgnoringCase(scopeValue, "row")) {

[tkent, 2016/09/28 00:23:08]

equalIgnoringCase should be equalIgnoringASCIICase.

https://html.spec.whatwg.org/multipage/infrastructure.html#enumerated-attribute

[rwlbuis, 2016/09/28 13:43:12]

Done :)

+        DEFINE_STATIC_LOCAL(const AtomicString, row, ("row"));
+        return row;
+    }
+    if (equalIgnoringCase(scopeValue, "col")) {
+        DEFINE_STATIC_LOCAL(const AtomicString, col, ("col"));
+        return col;
+    }
+    if (equalIgnoringCase(scopeValue, "rowgroup")) {
+        DEFINE_STATIC_LOCAL(const AtomicString, rowgroup, ("rowgroup"));
+        return rowgroup;
+    }
+    if (equalIgnoringCase(scopeValue, "colgroup")) {
+        DEFINE_STATIC_LOCAL(const AtomicString, colgroup, ("colgroup"));
+        return colgroup;
+    }
+    return emptyAtom;
+}
+
+void HTMLTableCellElement::setScope(const AtomicString& value)
+{
+    setAttribute(scopeAttr, value);
 }
 
 } // namespace blink