Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2376583002: DevTools: remove WI.NetworkMapping.networkURL (Closed)

Created:
4 years, 2 months ago by lushnikov
Modified:
4 years, 2 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove WI.NetworkMapping.networkURL Since crrev.com/2349343002, we can safely use UISourceCode.url() everywhere instead of networkMapping.networkURL(). BUG=649837 R=dgozman, pfeldman Committed: https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa Cr-Commit-Position: refs/heads/master@{#421640}

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 10

Patch Set 3 : address all but one comments #

Patch Set 4 : do not blackbox fs uiSourceCodes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -179 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/compiler-script-mapping.html View 3 chunks +3 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/elements/styles/update-locations-on-filesystem-scss-load.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/extensions/extensions-panel.html View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/jump-to-previous-editing-location.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html View 1 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js View 4 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping.html View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Tests.js View 1 2 3 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js View 5 chunks +5 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 3 chunks +5 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js View 4 chunks +3 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 3 chunks +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js View 1 2 6 chunks +10 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Linkifier.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 2 chunks +3 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesNavigator.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesSearchScope.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
lushnikov
please, take a look
4 years, 2 months ago (2016-09-27 02:30:30 UTC) #3
dgozman
https://codereview.chromium.org/2376583002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js (right): https://codereview.chromium.org/2376583002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js#newcode196 third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:196: return uiSourceCode.project().type() === WebInspector.projectTypes.Debugger ? null : uiSourceCode.url(); Looks ...
4 years, 2 months ago (2016-09-27 17:48:24 UTC) #7
lushnikov
All done! please, take a look https://codereview.chromium.org/2376583002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js File third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js (right): https://codereview.chromium.org/2376583002/diff/20001/third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js#newcode196 third_party/WebKit/Source/devtools/front_end/bindings/BlackboxManager.js:196: return uiSourceCode.project().type() === ...
4 years, 2 months ago (2016-09-28 18:36:02 UTC) #8
dgozman
lgtm
4 years, 2 months ago (2016-09-28 18:43:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376583002/60001
4 years, 2 months ago (2016-09-28 18:56:56 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-28 21:20:09 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 21:22:18 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/33cd9203a8749a54951037fa1017ec12c483a0aa
Cr-Commit-Position: refs/heads/master@{#421640}

Powered by Google App Engine
This is Rietveld 408576698