Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: blimp/client/core/BUILD.gn

Issue 2376573002: Cleanup blimp/client/core code organization. (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/rules.gni") 7 import("//build/config/android/rules.gni")
8 } 8 }
9 9
10 import("//blimp/client/core/config.gni") 10 import("//blimp/client/core/config.gni")
(...skipping 15 matching lines...) Expand all
26 } 26 }
27 } 27 }
28 28
29 group("core") { 29 group("core") {
30 visibility = [ 30 visibility = [
31 "//blimp/client/*", 31 "//blimp/client/*",
32 "//blimp/test/*", 32 "//blimp/test/*",
33 ] 33 ]
34 34
35 deps = [ 35 deps = [
36 ":context",
37 ":switches",
38 "//blimp/client/core/compositor", 36 "//blimp/client/core/compositor",
39 "//blimp/client/core/contents", 37 "//blimp/client/core/contents",
38 "//blimp/client/core/context",
40 "//blimp/client/core/geolocation", 39 "//blimp/client/core/geolocation",
41 "//blimp/client/core/render_widget", 40 "//blimp/client/core/render_widget",
42 "//blimp/client/core/session", 41 "//blimp/client/core/session",
43 "//blimp/client/core/settings", 42 "//blimp/client/core/settings",
43 "//blimp/client/core/switches",
44 ] 44 ]
45 } 45 }
46 46
47 source_set("dummy_core") { 47 group("dummy_core") {
48 visibility = [ ":*" ] 48 visibility = [ ":*" ]
49 49
50 sources = [ 50 deps = [
51 "dummy_blimp_client_context.cc", 51 "//blimp/client/core/context:dummy_context",
52 "dummy_blimp_client_context.h",
53 ] 52 ]
53 }
54
55 group("unit_tests") {
56 testonly = true
54 57
55 deps = [ 58 deps = [
56 "//base",
57 "//blimp/client/public:public_headers",
58 "//url",
59 ]
60
61 if (is_android) {
62 sources += [
63 "android/dummy_blimp_client_context_android.cc",
64 "android/dummy_blimp_client_context_android.h",
65 "android/dummy_blimp_jni_registrar.cc",
66 ]
67
68 deps += [ ":dummy_core_jni_headers" ]
69 }
70 }
71
72 source_set("unit_tests") {
73 testonly = true
74
75 sources = [
76 "blimp_client_context_impl_unittest.cc",
77 ]
78
79 deps = [
80 ":context",
81 "//blimp/client/core/compositor:unit_tests", 59 "//blimp/client/core/compositor:unit_tests",
82 "//blimp/client/core/contents:unit_tests", 60 "//blimp/client/core/contents:unit_tests",
61 "//blimp/client/core/context:unit_tests",
83 "//blimp/client/core/geolocation:unit_tests", 62 "//blimp/client/core/geolocation:unit_tests",
84 "//blimp/client/core/render_widget:unit_tests", 63 "//blimp/client/core/render_widget:unit_tests",
85 "//blimp/client/core/session:unit_tests", 64 "//blimp/client/core/session:unit_tests",
86 "//blimp/client/public:public_headers",
87 "//blimp/client/test",
88 "//testing/gmock",
89 "//testing/gtest",
90 ] 65 ]
91 } 66 }
92 67
93 source_set("context") {
94 sources = [
95 "blimp_client_context_impl.cc",
96 "blimp_client_context_impl.h",
97 ]
98
99 public_deps = [
100 "//base",
101 "//blimp/client/core/compositor:compositor",
102 "//blimp/client/core/contents",
103 "//blimp/client/core/session",
104 "//blimp/client/public:public_headers",
105 "//device/geolocation",
106 "//url",
107 ]
108
109 deps = [
110 ":switches",
111 "//blimp/client/core/geolocation",
112 "//blimp/client/core/settings",
113 ]
114
115 if (is_android) {
116 sources += [
117 "android/blimp_client_context_impl_android.cc",
118 "android/blimp_client_context_impl_android.h",
119 "android/blimp_jni_registrar.cc",
120 ]
121
122 deps += [
123 ":context_jni_headers",
124 "//blimp/client/core/settings",
125 "//ui/android",
126 ]
127 }
128 }
129
130 source_set("switches") {
131 visibility = [
132 "//blimp/client/*",
133 "//blimp/engine:browser_tests",
134 ]
135
136 sources = [
137 "blimp_client_switches.cc",
138 "blimp_client_switches.h",
139 ]
140 }
141
142 if (is_android) { 68 if (is_android) {
143 # This target is here to let //chrome depend on 69 # This target is here to let //chrome depend on
144 # //blimp/client/public:public_java and automatically get the correct 70 # //blimp/client/public:public_java and automatically get the correct
145 # implementation of //blimp/client/core depending on whether 71 # implementation of //blimp/client/core depending on whether
146 # enable_blimp_client is set or not. 72 # enable_blimp_client is set or not.
147 java_group("core_shim_java") { 73 java_group("core_shim_java") {
148 visibility = [ "//blimp/client/public/*" ] 74 visibility = [ "//blimp/client/public/*" ]
149 75
150 if (enable_blimp_client) { 76 if (enable_blimp_client) {
151 deps = [ 77 deps = [
152 ":core_java", 78 ":core_java",
153 ] 79 ]
154 } else { 80 } else {
155 deps = [ 81 deps = [
156 ":dummy_core_java", 82 ":dummy_core_java",
157 ] 83 ]
158 } 84 }
159 } 85 }
160 86
161 java_group("core_java") { 87 java_group("core_java") {
162 visibility = [ 88 visibility = [
163 "//blimp/client/*", 89 "//blimp/client/*",
164 "//blimp:blimp_unittests_java_deps", 90 "//blimp:blimp_unittests_java_deps",
165 ] 91 ]
166 92
167 deps = [ 93 deps = [
168 ":context_java",
169 ":switches_java",
170 "//blimp/client/core/contents:contents_java", 94 "//blimp/client/core/contents:contents_java",
95 "//blimp/client/core/context:context_java",
171 "//blimp/client/core/settings:settings_java", 96 "//blimp/client/core/settings:settings_java",
97 "//blimp/client/core/switches:switches_java",
172 "//device/geolocation:geolocation_java", 98 "//device/geolocation:geolocation_java",
173 ] 99 ]
174 } 100 }
175 101
176 android_library("dummy_core_java") { 102 java_group("dummy_core_java") {
177 visibility = [ ":*" ] 103 visibility = [ ":*" ]
178 104
179 java_files = [ "android/java/src/org/chromium/blimp/core/DummyBlimpClientCon text.java" ]
180
181 deps = [ 105 deps = [
182 "//base:base_java", 106 "//blimp/client/core/context:dummy_context_java",
183 "//blimp/client/public:public_headers_java",
184 "//ui/android:ui_java",
185 ] 107 ]
186 } 108 }
187
188 android_library("context_java") {
189 visibility = [ "//blimp/client/*" ]
190
191 java_files = [ "android/java/src/org/chromium/blimp/core/BlimpClientContextI mpl.java" ]
192
193 deps = [
194 ":common_java",
195 ":switches_java",
196 "//base:base_java",
197 "//blimp/client/core/contents:contents_java",
198 "//blimp/client/core/settings:settings_java",
199 "//blimp/client/public:public_headers_java",
200 "//ui/android:ui_java",
201 ]
202 }
203
204 android_library("common_java") {
205 visibility = [ "//blimp/client/*" ]
206
207 java_files = [ "android/java/src/org/chromium/blimp/core/settings/Preference sUtil.java" ]
208
209 deps = [
210 "//base:base_java",
211 "//blimp/client/public:public_headers_java",
212 ]
213 }
214
215 android_library("switches_java") {
216 visibility = [ "//blimp/client/*" ]
217
218 java_files =
219 [ "android/java/src/org/chromium/blimp/core/BlimpClientSwitches.java" ]
220 }
221
222 generate_jni("context_jni_headers") {
223 visibility = [ ":*" ]
224
225 sources = [
226 "android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java",
227 ]
228
229 jni_package = "blimp/client/core"
230 }
231
232 generate_jni("dummy_core_jni_headers") {
233 visibility = [ ":*" ]
234
235 sources = [
236 "android/java/src/org/chromium/blimp/core/DummyBlimpClientContext.java",
237 ]
238
239 jni_package = "blimp/client/core"
240 }
241 } 109 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698