Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2376563002: [modules] Don't throw when detecting cycle while processing star exports. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Don't throw when detecting cycle while processing star exports. We must not throw when seeing a cycle while trying to resolve a name through star exports. (It may be surprising that we do have to throw when seeing an ambiguity, but this is what the spec says.) R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/b7913f33a3d979d656016403a3c5d33e01e5734a Cr-Commit-Position: refs/heads/master@{#39787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M src/objects.h View 1 chunk +5 lines, -6 lines 0 comments Download
M src/objects.cc View 1 chunk +10 lines, -7 lines 0 comments Download
A + test/mjsunit/modules-fail-star-exports-conflict.js View 1 chunk +3 lines, -4 lines 0 comments Download
A + test/mjsunit/modules-skip-star-exports-conflict.js View 1 chunk +0 lines, -1 line 0 comments Download
A + test/mjsunit/modules-skip-star-exports-cycle.js View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/modules-star-exports-cycle.js View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
neis
4 years, 2 months ago (2016-09-27 01:07:35 UTC) #1
adamk
lgtm
4 years, 2 months ago (2016-09-27 17:25:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376563002/1
4 years, 2 months ago (2016-09-27 17:28:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 17:31:22 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:31:43 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7913f33a3d979d656016403a3c5d33e01e5734a
Cr-Commit-Position: refs/heads/master@{#39787}

Powered by Google App Engine
This is Rietveld 408576698