Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2376553002: chromeos: Add Screenshot_Annotate metric. (Closed)

Created:
4 years, 2 months ago by Daniel Erat
Modified:
4 years, 2 months ago
Reviewers:
jdufault, Mark P
CC:
chromium-reviews, kalyank, sadrul, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Add Screenshot_Annotate metric. Add a metric to measure clicks on the "Annotate" button in screenshot notifications. Also list additional owners for DownloadNotification.Button_Annotate. BUG=650497 TEST=manual: chrome://user-actions shows Screenshot_Annotate action after clicking button Committed: https://crrev.com/c68bc216f3acc97b4114785ccbb64d46fc65792f Cr-Commit-Position: refs/heads/master@{#421281}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M chrome/browser/ui/ash/chrome_screenshot_grabber.cc View 1 chunk +3 lines, -1 line 0 comments Download
M tools/metrics/actions/actions.xml View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Daniel Erat
4 years, 2 months ago (2016-09-27 15:40:34 UTC) #7
jdufault
lgtm
4 years, 2 months ago (2016-09-27 16:54:18 UTC) #8
Mark P
lgtm
4 years, 2 months ago (2016-09-27 17:26:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376553002/1
4 years, 2 months ago (2016-09-27 18:35:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 18:43:55 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 18:48:29 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c68bc216f3acc97b4114785ccbb64d46fc65792f
Cr-Commit-Position: refs/heads/master@{#421281}

Powered by Google App Engine
This is Rietveld 408576698