Chromium Code Reviews| Index: chrome/browser/search_engines/default_search_policy_handler_unittest.cc |
| diff --git a/chrome/browser/search_engines/default_search_policy_handler_unittest.cc b/chrome/browser/search_engines/default_search_policy_handler_unittest.cc |
| index 16189a6338c6c480694b19d39a1a55a232a3f253..b4ecbe4ee1fd760e1672c23edf5e1aae633dd441 100644 |
| --- a/chrome/browser/search_engines/default_search_policy_handler_unittest.cc |
| +++ b/chrome/browser/search_engines/default_search_policy_handler_unittest.cc |
| @@ -3,12 +3,20 @@ |
| // found in the LICENSE file. |
| #include "base/memory/scoped_ptr.h" |
| +#include "chrome/browser/search_engines/default_search_manager.h" |
| #include "chrome/browser/search_engines/default_search_policy_handler.h" |
| #include "chrome/common/pref_names.h" |
| #include "components/policy/core/browser/configuration_policy_pref_store.h" |
| #include "components/policy/core/browser/configuration_policy_pref_store_test.h" |
| #include "policy/policy_constants.h" |
| +namespace { |
| +// TODO(caitkp): Should we find a way to route this through DefaultSearchManager |
| +// to avoid hardcoding this here? |
| +const char kDefaultSearchProviderData[] = |
| + "default_search_provider_data.template_url_data"; |
| +} // namespace |
| + |
| namespace policy { |
| class DefaultSearchPolicyHandlerTest |
| @@ -297,4 +305,84 @@ TEST_F(DefaultSearchPolicyHandlerTest, Disabled) { |
| EXPECT_TRUE(base::Value::Equals(&expected_search_url, value)); |
| } |
| +// Checks that for a fully defined search policy, all elements have been |
| +// read properly into the dictionary pref. |
| +TEST_F(DefaultSearchPolicyHandlerTest, DictionaryPref) { |
| + PolicyMap policy; |
| + BuildDefaultSearchPolicy(&policy); |
| + UpdateProviderPolicy(policy); |
| + |
| + const base::Value* temp = NULL; |
| + const base::DictionaryValue* dictionary; |
| + std::string value; |
| + const base::ListValue* list_value; |
| + EXPECT_TRUE(store_->GetValue(kDefaultSearchProviderData, &temp)); |
| + temp->GetAsDictionary(&dictionary); |
| + |
| + EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kURL, &value)); |
| + EXPECT_EQ(kSearchURL, value); |
| + EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kShortName, &value)); |
| + EXPECT_EQ(kName, value); |
| + EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kKeyword, &value)); |
| + EXPECT_EQ(kKeyword, value); |
| + |
| + EXPECT_TRUE( |
| + dictionary->GetString(DefaultSearchManager::kSuggestionsURL, &value)); |
| + EXPECT_EQ(kSuggestURL, value); |
| + EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kFaviconURL, &value)); |
| + EXPECT_EQ(kIconURL, value); |
| + |
| + base::ListValue encodings; |
| + encodings.AppendString("UTF-16"); |
| + encodings.AppendString("UTF-8"); |
| + |
| + EXPECT_TRUE( |
| + dictionary->GetList(DefaultSearchManager::kInputEncodings, &list_value)); |
| + EXPECT_TRUE(encodings.Equals(list_value)); |
| + |
| + EXPECT_TRUE( |
| + dictionary->GetList(DefaultSearchManager::kAlternateURLs, &list_value)); |
| + EXPECT_TRUE(default_alternate_urls_.Equals(list_value)); |
| + |
| + EXPECT_TRUE(dictionary->GetString( |
| + DefaultSearchManager::kSearchTermsReplacementKey, &value)); |
| + EXPECT_EQ(kReplacementKey, value); |
| + |
| + EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kImageURL, &value)); |
| + EXPECT_EQ(kImageURL, value); |
| + |
| + EXPECT_TRUE( |
| + dictionary->GetString(DefaultSearchManager::kImageURLPostParams, &value)); |
| + EXPECT_EQ(kImageParams, value); |
| + |
| + EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kSearchURLPostParams, |
| + &value)); |
| + EXPECT_EQ(std::string(), value); |
| + |
| + EXPECT_TRUE(dictionary->GetString( |
| + DefaultSearchManager::kSuggestionsURLPostParams, &value)); |
| + EXPECT_EQ(std::string(), value); |
| + |
| + EXPECT_TRUE(dictionary->GetString(DefaultSearchManager::kInstantURLPostParams, |
| + &value)); |
| + EXPECT_EQ(std::string(), value); |
| +} |
| + |
| +// Checks that disabling default search is properly reflected the dictionary |
| +// pref. |
| +TEST_F(DefaultSearchPolicyHandlerTest, DictionaryPrefDSEDisabled) { |
| + PolicyMap policy; |
| + policy.Set(key::kDefaultSearchProviderEnabled, POLICY_LEVEL_MANDATORY, |
| + POLICY_SCOPE_USER, base::Value::CreateBooleanValue(false), NULL); |
|
Peter Kasting
2014/04/29 01:47:32
Nit: Indenting
Cait (Slow)
2014/04/29 17:14:51
Done.
|
| + UpdateProviderPolicy(policy); |
| + const base::Value* temp = NULL; |
| + const base::DictionaryValue* dictionary; |
| + EXPECT_TRUE(store_->GetValue(kDefaultSearchProviderData, &temp)); |
| + temp->GetAsDictionary(&dictionary); |
| + bool disabled = false; |
| + EXPECT_TRUE(dictionary->GetBoolean(DefaultSearchManager::kDisabledByPolicy, |
| + &disabled)); |
| + EXPECT_TRUE(disabled); |
| + |
| +} |
| } // namespace policy |