Add VisitedLinkNotificationSink to renderer's browser capability

Add VisitedLinkNotificationSink to renderer's browser capability

BUG=650364
TBR=ben@chromium.org

Committed: https://crrev.com/7ebc48c59be5ca12c0ebec989c46aeb4e6c7612b
Cr-Commit-Position: refs/heads/master@{#421073}

[Ken Rockot(use gerrit already), 2016-09-26 19:28:59]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-09-26 19:29:10]

Description was changed from

==========
Add VisitedLinkNotificationSink to browser's web capability

BUG=650364
==========

to

==========
Add VisitedLinkNotificationSink to browser's web capability

BUG=650364
TBR=ben@chromium.org
==========

[commit-bot: I haz the power, 2016-09-26 19:29:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-09-26 19:31:20]

rockot@chromium.org changed reviewers:
+ dcheng@chromium.org

[Ken Rockot(use gerrit already), 2016-09-26 19:31:21]

This is probably breaking stuff in the wild but I couldn't find any specific
bugs that looked relevant. I imagine it's subtle enough that the effects are
hard to notice in Canary/Dev.

Anyway, it was fairly easy to catch from the log spam it was causing:

[1:2:0926/121923:ERROR:interface_registry.cc(93)] Capability spec prevented
service: exe:content_browser from binding interface:
visitedlink::mojom::VisitedLinkNotificationSink
[1:2:0926/121923:ERROR:interface_registry.cc(93)] Capability spec prevented
service: exe:content_browser from binding interface:
visitedlink::mojom::VisitedLinkNotificationSink
[1:2:0926/121923:ERROR:interface_registry.cc(93)] Capability spec prevented
service: exe:content_browser from binding interface:
visitedlink::mojom::VisitedLinkNotificationSink
[1:2:0926/121924:ERROR:interface_registry.cc(93)] Capability spec prevented
service: exe:content_browser from binding interface:
visitedlink::mojom::VisitedLinkNotificationSink
[1:2:0926/121928:ERROR:interface_registry.cc(93)] Capability spec prevented
service: exe:content_browser from binding interface:
visitedlink::mojom::VisitedLinkNotificationSink


I think any kind of assert here, even a DCHECK, would unfortunately be the wrong
thing to do.

[Ken Rockot(use gerrit already), 2016-09-26 19:36:07]

Description was changed from

==========
Add VisitedLinkNotificationSink to browser's web capability

BUG=650364
TBR=ben@chromium.org
==========

to

==========
Add VisitedLinkNotificationSink to renderer's browser capability

BUG=650364
TBR=ben@chromium.org
==========

[Ken Rockot(use gerrit already), 2016-09-26 19:36:19]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-09-26 19:36:38]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2016-09-26 19:36:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-09-26 19:56:51]

Is it possible to confirm that visited link highlights aren't working?

[Ken Rockot(use gerrit already), 2016-09-26 20:08:48]

Aye. Confirmed that highlights are broken before this CL and fixed after. Bug
description updated accordingly as well.

[commit-bot: I haz the power, 2016-09-26 20:22:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:22:18]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dcheng, 2016-09-26 20:25:59]

LGTM

Sure would be nice if we had some sort of test thingie for this... =)

[Ken Rockot(use gerrit already), 2016-09-26 20:28:13]

On 2016/09/26 at 20:25:59, dcheng wrote:
> LGTM
> 
> Sure would be nice if we had some sort of test thingie for this... =)

I agree!

[Ken Rockot(use gerrit already), 2016-09-26 20:28:16]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-09-26 20:28:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 23:40:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 23:40:29]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-09-27 00:01:35]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-09-27 00:03:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 01:34:12]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-09-27 01:39:18]

Description was changed from

==========
Add VisitedLinkNotificationSink to renderer's browser capability

BUG=650364
TBR=ben@chromium.org
==========

to

==========
Add VisitedLinkNotificationSink to renderer's browser capability

BUG=650364
TBR=ben@chromium.org

Committed: https://crrev.com/7ebc48c59be5ca12c0ebec989c46aeb4e6c7612b
Cr-Commit-Position: refs/heads/master@{#421073}
==========

[commit-bot: I haz the power, 2016-09-27 01:39:19]

Patchset 1 (id:??) landed as
https://crrev.com/7ebc48c59be5ca12c0ebec989c46aeb4e6c7612b
Cr-Commit-Position: refs/heads/master@{#421073}