Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: runtime/observatory/tests/service/debugger_location_test.dart

Issue 2376433003: Split debugger_location_test into two separate tests (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/debugger_location_test.dart
diff --git a/runtime/observatory/tests/service/debugger_location_test.dart b/runtime/observatory/tests/service/debugger_location_test.dart
index 53ed4fb97c1fc497cdb3f4e7b65347f8e5066d9a..a637a830ffd36a0f8e0c597ab26f78f350512902 100644
--- a/runtime/observatory/tests/service/debugger_location_test.dart
+++ b/runtime/observatory/tests/service/debugger_location_test.dart
@@ -150,139 +150,6 @@ hasStoppedAtBreakpoint,
'DebuggerLocationTestFoo.DebuggerLocationTestFoo.named'));
},
-// Parse method
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var loc =
- await DebuggerLocation.parse(debugger, 'DebuggerLocationTestFoo.method');
- expect(loc.valid, isTrue);
- expect(loc.toString(), equals('DebuggerLocationTestFoo.method'));
-},
-
-// Parse method
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var loc =
- await DebuggerLocation.parse(debugger, 'DebuggerLocationTestFoo.field=');
- expect(loc.valid, isTrue);
- expect(loc.toString(), equals('DebuggerLocationTestFoo.field='));
-},
-
-// Parse bad method
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var loc =
- await DebuggerLocation.parse(debugger, 'DebuggerLocationTestFoo.missing');
- expect(loc.valid, isFalse);
- expect(loc.toString(), equals(
- 'invalid source location '
- '(Function \'DebuggerLocationTestFoo.missing\' not found)'));
-},
-
-// Complete function + script
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions = await DebuggerLocation.complete(debugger, 'debugger_loc');
- expect(completions.toString(), equals(
- '[debugger_location_dummy_function,'
- ' debugger_location.dart:,'
- ' debugger_location_test.dart:]'));
-},
-
-// Complete class
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions =
- await DebuggerLocation.complete(debugger, 'DebuggerLocationTe');
- expect(completions.toString(), equals(
- '[DebuggerLocationTestBar,'
- ' DebuggerLocationTestFoo]'));
-},
-
-// No completions: unqualified name
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions =
- await DebuggerLocation.complete(debugger, 'debugger_locXYZZY');
- expect(completions.toString(), equals('[]'));
-},
-
-// Complete method
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions =
- await DebuggerLocation.complete(debugger, 'DebuggerLocationTestFoo.m');
- expect(completions.toString(), equals(
- '[DebuggerLocationTestFoo.madness,'
- ' DebuggerLocationTestFoo.method]'));
-},
-
-// No completions: qualified name
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions =
- await DebuggerLocation.complete(debugger, 'DebuggerLocationTestFoo.q');
- expect(completions.toString(), equals('[]'));
-},
-
-// Complete script
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions =
- await DebuggerLocation.complete(debugger, 'debugger_location_te');
- expect(completions.toString(), equals(
- '[debugger_location_test.dart:]'));
-},
-
-// Complete script:line
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions =
- await DebuggerLocation.complete(debugger,
- 'debugger_location_test.dart:11');
- expect(completions.toString(), equals(
- '[debugger_location_test.dart:${LINE_B + 0} ,'
- ' debugger_location_test.dart:${LINE_B + 0}:,'
- ' debugger_location_test.dart:${LINE_B + 1} ,'
- ' debugger_location_test.dart:${LINE_B + 1}:,'
- ' debugger_location_test.dart:${LINE_B + 2} ,'
- ' debugger_location_test.dart:${LINE_B + 2}:,'
- ' debugger_location_test.dart:${LINE_B + 3} ,'
- ' debugger_location_test.dart:${LINE_B + 3}:,'
- ' debugger_location_test.dart:${LINE_B + 4} ,'
- ' debugger_location_test.dart:${LINE_B + 4}:,'
- ' debugger_location_test.dart:${LINE_B + 5} ,'
- ' debugger_location_test.dart:${LINE_B + 5}:]'));
-},
-
-// Complete script:line:col
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions =
- await DebuggerLocation.complete(debugger,
- 'debugger_location_test.dart:$LINE_C:2');
- expect(completions.toString(), equals(
- '[debugger_location_test.dart:$LINE_C:2 ,'
- ' debugger_location_test.dart:$LINE_C:20 ,'
- ' debugger_location_test.dart:$LINE_C:21 ,'
- ' debugger_location_test.dart:$LINE_C:22 ,'
- ' debugger_location_test.dart:$LINE_C:23 ,'
- ' debugger_location_test.dart:$LINE_C:24 ]'));
-},
-
-// Complete without the script name.
-(Isolate isolate) async {
- var debugger = await initDebugger(isolate);
- var completions = await DebuggerLocation.complete(debugger, '$LINE_C:2');
- expect(completions.toString(), equals(
- '[debugger_location_test.dart:$LINE_C:2 ,'
- ' debugger_location_test.dart:$LINE_C:20 ,'
- ' debugger_location_test.dart:$LINE_C:21 ,'
- ' debugger_location_test.dart:$LINE_C:22 ,'
- ' debugger_location_test.dart:$LINE_C:23 ,'
- ' debugger_location_test.dart:$LINE_C:24 ]'));
-},
-
];
main(args) => runIsolateTests(args, tests, testeeConcurrent: testFunction);
« no previous file with comments | « runtime/observatory/tests/service/debugger_location_second_test.dart ('k') | runtime/observatory/tests/service/service.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698