Chromium Code Reviews| Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp |
| diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp |
| index c522068d322638466cb955d30e1da14207199146..8e4ee03bc5707a49cc5ecff53989fca30c1662c6 100644 |
| --- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp |
| +++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp |
| @@ -188,9 +188,10 @@ void ServiceWorkerGlobalScopeProxy::dispatchForeignFetchEvent( |
| const WebServiceWorkerRequest& webRequest) { |
| if (!OriginTrials::foreignFetchEnabled(workerGlobalScope())) { |
| // If origin trial tokens have expired, or are otherwise no longer valid |
| - // no events should be dispatched. |
| - // TODO(mek): Ideally the browser wouldn't even start the service worker |
| - // if its tokens have expired. |
| + // no events should be dispatched. We can check it in the browser process if |
| + // the service worker is installed after M56. But if the service worker is |
| + // installed in old version of Chrome (<M55) we have to check it in the |
|
falken
2016/10/07 05:38:33
"is installed" -> "was installed" (two places)
horo
2016/10/07 08:29:42
Done.
|
| + // renderer process. |
|
falken
2016/10/07 05:38:33
maybe add "renderer process (here)" for clarity
|
| ServiceWorkerGlobalScopeClient::from(workerGlobalScope()) |
| ->respondToFetchEvent(responseID, WTF::currentTime()); |
| ServiceWorkerGlobalScopeClient::from(workerGlobalScope()) |