Make toasts notice when they're hidden and send the mouse-out event.

Make toasts notice when they're hidden and send the mouse-out event.

A recent change in Views causes the mouse move trackers to be
removed when visibility changes, causing the mouseexited event never
to happen if a window is closed underneath the mouse.

BUG=282117
R=mukai@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220691

[dewittj, 2013-08-30 17:11:57]

mukai: PTAL

[sadrul, 2013-08-30 17:18:31]

drive-by

https://codereview.chromium.org/23764003/diff/1/ui/message_center/views/toast...
File ui/message_center/views/toast_contents_view.cc (right):

https://codereview.chromium.org/23764003/diff/1/ui/message_center/views/toast...
ui/message_center/views/toast_contents_view.cc:251:
collection_->RemoveToast(this);
I think it makes more sense for RemoveToast() to reset its states correctly,
than to override VisibilityChanged()?

[dewittj, 2013-08-30 17:29:24]

https://codereview.chromium.org/23764003/diff/1/ui/message_center/views/toast...
File ui/message_center/views/toast_contents_view.cc (right):

https://codereview.chromium.org/23764003/diff/1/ui/message_center/views/toast...
ui/message_center/views/toast_contents_view.cc:251:
collection_->RemoveToast(this);
On 2013/08/30 17:18:31, sadrul wrote:
> I think it makes more sense for RemoveToast() to reset its states correctly,
> than to override VisibilityChanged()?

Done.

[Jun Mukai, 2013-08-30 17:43:44]

lgtm

[commit-bot: I haz the power, 2013-08-30 17:47:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/23764003/10001

[sadrul, 2013-08-30 17:47:57]

Please consider adding a test for this case too.

[dewittj, 2013-08-30 20:31:08]

On 2013/08/30 17:47:57, sadrul wrote:
> Please consider adding a test for this case too.

Added.  Thanks!

[commit-bot: I haz the power, 2013-08-30 20:32:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dewittj@chromium.org/23764003/28001

[dewittj, 2013-08-31 00:05:47]

Committed patchset #4 manually as r220691 (presubmit successful).