Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Issue 2376323003: Include addresses with the getdetailsforsavecard Payments RPC. (Closed)

Created:
4 years, 2 months ago by Justin Donnelly
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Include addresses with the getdetailsforsavecard Payments RPC. These addresses will be used by Payments to determine the correct legal documents to show the user and to verify that the addresses are valid for their purposes (and thus won't fail on any subsequent save). Names and phone numbers are removed from the addresses before uploading since they are not useful for these purposes. BUG=535784 Committed: https://crrev.com/da7eb69a380d53eec42cc4e620e55b78e5d6fa82 Review-Url: https://codereview.chromium.org/2349033002 Cr-Original-Commit-Position: refs/heads/master@{#420409} Cr-Commit-Position: refs/heads/master@{#420893} (cherry picked from commit 005d6cd78d14cb1d68a92a0d8dd9a98595b54d80) Committed: https://chromium.googlesource.com/chromium/src/+/be023346b6939f20fafbed8612f1bbf4bdf6ca52

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -15 lines) Patch
M components/autofill/content/browser/payments/payments_client_unittest.cc View 6 chunks +88 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/autofill/core/browser/payments/payments_client.h View 2 chunks +11 lines, -2 lines 0 comments Download
M components/autofill/core/browser/payments/payments_client.cc View 9 chunks +40 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Justin Donnelly
4 years, 2 months ago (2016-09-29 17:06:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be023346b6939f20fafbed8612f1bbf4bdf6ca52.

Powered by Google App Engine
This is Rietveld 408576698