Source/core/rendering/RenderBlock.h - Issue 23763002: Improve multicol preferred/intrinsic width calculation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlock.h

Issue 23763002: Improve multicol preferred/intrinsic width calculation. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/platform/win/fast/multicol/positioned-with-constrained-height-expected.txt ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBlock.h

diff --git a/Source/core/rendering/RenderBlock.h b/Source/core/rendering/RenderBlock.h

index 24cc7472c7b08f796ac5f23eb90d7ffc64825d03..3c725b3ea8863974bf329c01a182329d36afada4 100644

--- a/Source/core/rendering/RenderBlock.h

+++ b/Source/core/rendering/RenderBlock.h

@@ -523,6 +523,7 @@ protected:

virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const OVERRIDE;

virtual void computePreferredLogicalWidths() OVERRIDE;

+ void adjustIntrinsicLogicalWidthsForColumns(LayoutUnit& minLogicalWidth, LayoutUnit& maxLogicalWidth) const;

virtual int firstLineBoxBaseline() const;

virtual int inlineBlockBaseline(LineDirectionMode) const OVERRIDE;