cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function.

chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

Index: chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
diff --git a/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js b/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
index 67d62ec907524bc94e66cba33b98a2a9b8c70ae0..65a70d474fdc74fd622534a5f3b828541d19135a 100644
--- a/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
+++ b/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
@@ -337,6 +337,7 @@ cr.define('settings_people_page_quick_unlock', function() {
 
         // Create setup-pin element.
         element = document.createElement('settings-setup-pin-dialog');
+        element.quickUnlockPrivate_ = quickUnlockPrivateApi;
         element.setModes =
             quickUnlockPrivateApi.setModes.bind(quickUnlockPrivateApi, '');
         element.writeUma_ = fakeUma.recordProgress.bind(fakeUma);
@@ -402,13 +403,25 @@ cr.define('settings_people_page_quick_unlock', function() {
         pinKeyboard.value = '11';
 
         assertTrue(isVisible(problemDiv));
-        assertHasClass(problemDiv, 'warning');
+        assertHasClass(problemDiv, 'error');
+        assertTrue(continueButton.disabled);
+      });
+
+      // If the PIN is too long an error problem is shown.
+      test('WarningShownForLongPins', function() {
+        // By default, there is no max length on pins.
+        quickUnlockPrivateApi.credentialRequirements.maxLength = 5;
+
+        pinKeyboard.value = '111111';
+
+        assertTrue(isVisible(problemDiv));
+        assertHasClass(problemDiv, 'error');
         assertTrue(continueButton.disabled);

[stevenjb, 2017/01/03 18:35:13]

We should also test that a shorter pin is valid when maxLength is set.

[sammiequon, 2017/01/03 22:15:07]

Done.

       });
 
       // If the PIN is weak a warning problem is shown.
       test('WarningShownForWeakPins', function() {
-        pinKeyboard.value = '111111';
+        pinKeyboard.value = '1111';
 
         assertTrue(isVisible(problemDiv));
         assertHasClass(problemDiv, 'warning');
@@ -425,8 +438,9 @@ cr.define('settings_people_page_quick_unlock', function() {
         assertTrue(isVisible(problemDiv));
         assertHasClass(problemDiv, 'warning');
 
-        // Submitting a mistmatched PIN shows an error.
-        MockInteractions.tap(continueButton);
+        // Submitting a mistmatched PIN shows an error. Directly call the button
+        // event since a tap on the disabled button does nothing.
+        element.onPinSubmit_();
         assertHasClass(problemDiv, 'error');
 
         // Changing the PIN changes the error to a warning.