chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2376293005: cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2376293005: cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function. (Closed)

Patch Set: Added a comment. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/people_page/setup_pin_dialog.js ('K') | « chrome/browser/ui/webui/options/browser_options_handler.cc ('k') | chrome/test/data/webui/settings/fake_quick_unlock_private.js » ('j') | third_party/closure_compiler/externs/quick_unlock_private.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index df9faab6295329d02fbde597df4531beb39c0f37..d66c0b2175577d7dd3dde4f1a1bb978b7a772e64 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -1062,6 +1062,7 @@ void AddPeopleStrings(content::WebUIDataSource* html_source) {

IDS_SETTINGS_PEOPLE_CONFIGURE_PIN_CONTINUE_BUTTON},

{"configurePinMismatched", IDS_SETTINGS_PEOPLE_CONFIGURE_PIN_MISMATCHED},

{"configurePinTooShort", IDS_SETTINGS_PEOPLE_CONFIGURE_PIN_TOO_SHORT},

+ {"configurePinTooLong", IDS_SETTINGS_PEOPLE_CONFIGURE_PIN_TOO_LONG},

{"configurePinWeakPin", IDS_SETTINGS_PEOPLE_CONFIGURE_PIN_WEAK_PIN},

{"enableScreenlock", IDS_SETTINGS_PEOPLE_ENABLE_SCREENLOCK},

{"lockScreenChangePinButton",