cros: Tweaked the good/bad pin checking on the js to use the new quick unlock api function.

chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_people_page_quick_unlock', function() {
   var element = null;
   var quickUnlockPrivateApi = null;
   var QuickUnlockMode = chrome.quickUnlockPrivate.QuickUnlockMode;
   var fakeUma = null;
 
@@ skipping 319 matching lines @@
       });
 
       setup(function() {
         PolymerTest.clearBody();
 
         quickUnlockPrivateApi = new settings.FakeQuickUnlockPrivate();
         fakeUma = new settings.FakeQuickUnlockUma();
 
         // Create setup-pin element.
         element = document.createElement('settings-setup-pin-dialog');
+        element.quickUnlockPrivate_ = quickUnlockPrivateApi;
         element.setModes =
             quickUnlockPrivateApi.setModes.bind(quickUnlockPrivateApi, '');
         element.writeUma_ = fakeUma.recordProgress.bind(fakeUma);
 
         document.body.appendChild(element);
         Polymer.dom.flush();
 
         element.open();
 
         titleDiv = getFromElement('div[class="title"]');
@@ skipping 45 matching lines @@
 
         pinKeyboard.value = '';
         assertTrue(isVisible(problemDiv));
       });
 
       // If the PIN is too short an error problem is shown.
       test('WarningShownForShortPins', function() {
         pinKeyboard.value = '11';
 
         assertTrue(isVisible(problemDiv));
-        assertHasClass(problemDiv, 'warning');
+        assertHasClass(problemDiv, 'error');
+        assertTrue(continueButton.disabled);
+      });
+
+      // If the PIN is too long an error problem is shown.
+      test('WarningShownForLongPins', function() {
+        // By default, there is no max length on pins.
+        quickUnlockPrivateApi.credentialRequirements.maxLength = 5;
+
+        pinKeyboard.value = '111111';
+
+        assertTrue(isVisible(problemDiv));
+        assertHasClass(problemDiv, 'error');
         assertTrue(continueButton.disabled);

[stevenjb, 2017/01/03 18:35:13]

We should also test that a shorter pin is valid when maxLength is set.

[sammiequon, 2017/01/03 22:15:07]

Done.

       });
 
       // If the PIN is weak a warning problem is shown.
       test('WarningShownForWeakPins', function() {
-        pinKeyboard.value = '111111';
+        pinKeyboard.value = '1111';
 
         assertTrue(isVisible(problemDiv));
         assertHasClass(problemDiv, 'warning');
       });
 
       // If the confirm PIN does not match the initial PIN a warning is shown.
       // If the user tries to submit the PIN, the warning changes to an error.
       test('WarningThenErrorShownForMismatchedPins', function() {
         pinKeyboard.value = '1118';
         MockInteractions.tap(continueButton);
 
         // Entering a mismatched PIN shows a warning.
         pinKeyboard.value = '1119';
         assertTrue(isVisible(problemDiv));
         assertHasClass(problemDiv, 'warning');
 
-        // Submitting a mistmatched PIN shows an error.
-        MockInteractions.tap(continueButton);
+        // Submitting a mistmatched PIN shows an error. Directly call the button
+        // event since a tap on the disabled button does nothing.
+        element.onPinSubmit_();
         assertHasClass(problemDiv, 'error');
 
         // Changing the PIN changes the error to a warning.
         pinKeyboard.value = '111';
         assertHasClass(problemDiv, 'warning');
       });
 
       // Hitting cancel at the setup step dismisses the dialog.
       test('HittingBackButtonResetsState', function() {
         MockInteractions.tap(backButton);
@@ skipping 39 matching lines @@
       });
     });
   }
 
   return {
     registerAuthenticateTests: registerAuthenticateTests,
     registerLockScreenTests: registerLockScreenTests,
     registerSetupPinDialogTests: registerSetupPinDialogTests
   };
 });