Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2376293002: [parser] Refactor of ParseFunctionDeclaration (Closed)

Created:
4 years, 2 months ago by nickie
Modified:
4 years, 2 months ago
Reviewers:
adamk, Toon Verwaest
CC:
v8-reviews_googlegroups.com, marja
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Refactor of ParseFunctionDeclaration This patch moves the method ParseFunctionDeclaration to ParserBase. It also cleans up some forgotten method headers in parser and preparser. R=adamk@chromium.org, verwaest@chromium.org BUG= LOG=N Committed: https://crrev.com/ccd712040b98289068925eb5e4dda04ccbcac1e3 Cr-Commit-Position: refs/heads/master@{#39901}

Patch Set 1 : Just moving code (broken) #

Patch Set 2 : The real patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -49 lines) Patch
M src/parsing/parser.h View 2 chunks +0 lines, -3 lines 0 comments Download
M src/parsing/parser.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/parsing/parser-base.h View 1 4 chunks +21 lines, -2 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/parsing/preparser.cc View 2 chunks +1 line, -24 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
nickie
4 years, 2 months ago (2016-09-29 09:35:58 UTC) #1
nickie
This is the safe part of 2366903002, which was closed and will be redesigned. I'm ...
4 years, 2 months ago (2016-09-29 09:39:29 UTC) #5
Toon Verwaest
lgtm
4 years, 2 months ago (2016-09-29 12:57:09 UTC) #8
adamk
lgtm
4 years, 2 months ago (2016-09-29 17:29:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376293002/20001
4 years, 2 months ago (2016-09-30 07:56:25 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 08:03:24 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 08:03:49 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ccd712040b98289068925eb5e4dda04ccbcac1e3
Cr-Commit-Position: refs/heads/master@{#39901}

Powered by Google App Engine
This is Rietveld 408576698