Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2376263002: [Findit] Renaming version property in versioned_model.py to avoid conflicts with base_analysis.py (Closed)

Created:
4 years, 2 months ago by lijeffrey
Modified:
4 years, 2 months ago
Reviewers:
chanli, stgao
CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Renaming version property in versioned_model.py to avoid conflicts with base_analysis.py BUG=651269 Committed: https://chromium.googlesource.com/infra/infra/+/661cbd1e045c5bf4d5f100a976e101ce71d5545c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M appengine/findit/handlers/config.py View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/model/test/versioned_config_test.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/model/test/versioned_model_test.py View 6 chunks +7 lines, -7 lines 0 comments Download
M appengine/findit/model/versioned_model.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
lijeffrey
ptal
4 years, 2 months ago (2016-09-29 04:15:17 UTC) #3
stgao
lgtm
4 years, 2 months ago (2016-09-29 04:21:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376263002/1
4 years, 2 months ago (2016-09-29 05:08:14 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 05:22:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/661cbd1e045c5bf4d5f100a976e10...

Powered by Google App Engine
This is Rietveld 408576698