Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2376253002: Revert of PPC/s390: [sysroot installer] Disable for host arch PPC/s390 (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
agrieve, JaideepBajwa
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of PPC/s390: [sysroot installer] Disable for host arch PPC/s390 (patchset #3 id:40001 of https://codereview.chromium.org/2368943005/ ) Reason for revert: This causes failures in gclient runhooks on 32 bit machines: https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/builds/10626 Log snippet: running 'E:\b\depot_tools\python276_bin\python.exe src/build/linux/sysroot_scripts/install-sysroot.py Unrecognized host arch: x86 Original issue's description: > PPC/s390: [sysroot installer] Disable for host arch PPC/s390 > > Since PPC/s390 doesn't have the sysroot files available > on google storage, disabling it so that the script doesn't > cause gclient sync to fail when run on PPC/s390. > > R=agrieve@chromium.org > > BUG= > LOG=N > > Committed: https://crrev.com/5e5689bba0a51bad28c08bf3a3820da57a185c3b > Cr-Commit-Position: refs/heads/master@{#421722} TBR=agrieve@chromium.org,bjaideep@ca.ibm.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/9cc67cbe3ea5b54c3fc8f6793e947150182f3c2b Cr-Commit-Position: refs/heads/master@{#421735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M AUTHORS View 2 chunks +0 lines, -2 lines 0 comments Download
M build/detect_host_arch.py View 1 chunk +1 line, -6 lines 0 comments Download
M build/linux/sysroot_scripts/install-sysroot.py View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tsergeant
Created Revert of PPC/s390: [sysroot installer] Disable for host arch PPC/s390
4 years, 2 months ago (2016-09-29 03:26:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376253002/1
4 years, 2 months ago (2016-09-29 03:26:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 03:29:06 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 03:31:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9cc67cbe3ea5b54c3fc8f6793e947150182f3c2b
Cr-Commit-Position: refs/heads/master@{#421735}

Powered by Google App Engine
This is Rietveld 408576698