Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2376233005: [NotForReview] An idea for experimenting purge & suspend (Closed)

Created:
4 years, 2 months ago by bashi
Modified:
4 years, 1 month ago
Reviewers:
haraken, tasak
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NotForReview] An idea for experimenting purge & suspend BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
M content/browser/memory/memory_coordinator.h View 2 chunks +8 lines, -0 lines 0 comments Download
M content/browser/memory/memory_coordinator.cc View 2 chunks +17 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/child/memory/child_memory_coordinator_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/memory/child_memory_coordinator_impl.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
bashi
tasak@: This is what was in mind at yesterday's sync-up. Just want to share an ...
4 years, 2 months ago (2016-09-30 02:38:57 UTC) #2
haraken
Just to confirm: You're assuming that the existing TabManager (which will be replaced with MemoryCoordinator ...
4 years, 2 months ago (2016-09-30 05:46:27 UTC) #3
bashi
4 years, 2 months ago (2016-09-30 05:54:06 UTC) #4 
On 2016/09/30 05:46:27, haraken wrote:
> Just to confirm: You're assuming that the existing TabManager (which will be
> replaced with MemoryCoordinator in the future) will dispatch
> RenderProcessHostImpl::PurgeAndSuspend(), right?

Yes. But the main reason I didn't touch TabManager is that it lives in chrome/,
not in content/. If we expose MemoryCoordinator::PurgeAndSuspend() to chrome/
(by putting a method in content/public), we can tweak a logic in TabManager.
Again, this is just an idea and I'm not sure it's worth doing because it will
make the implementation more complicated.

Powered by Google App Engine
This is Rietveld 408576698