Instantiate parameterized types of type parameters with 'dynamic' type arguments.

pkg/analyzer/lib/src/dart/element/element.dart

Index: pkg/analyzer/lib/src/dart/element/element.dart
diff --git a/pkg/analyzer/lib/src/dart/element/element.dart b/pkg/analyzer/lib/src/dart/element/element.dart
index 4118d8d5d360f48760e75d9957260cc3f6a7c576..c6c7d4fe4d82e7cadfef394a35a43f8fc5350234 100644
--- a/pkg/analyzer/lib/src/dart/element/element.dart
+++ b/pkg/analyzer/lib/src/dart/element/element.dart
@@ -8141,7 +8141,8 @@ abstract class TypeParameterizedElementMixin
         (unlinkedTypeParams != null && unlinkedTypeParams[i].bound == null)) {
       return DynamicTypeImpl.instance;
     }
-    return typeParameters[i].bound ?? DynamicTypeImpl.instance;
+    DartType bound = typeParameters[i].bound ?? DynamicTypeImpl.instance;

[Jennifer Messerly, 2016/09/30 00:22:38]

there's also resolveToBound on DartType, not sure if that would be helpful

Given how we tend use lazy substitutions I don't usually have a good mental
model of what the difference is between all of these operations :|

+    return new TypeSystemImpl().instantiateToBounds(bound);

[Jennifer Messerly, 2016/09/30 00:22:38]

if we reach this line, we know we're in strongMode right -- because of the "if"
above?

in that case, shouldn't this be StrongTypeSystemImpl?

[scheglov, 2016/09/30 03:42:39]

Yes, typeSystem is always StrongTypeSystemImpl in this case.

AFAIK we decided that when type parameter has bound, and the bound is a
parameterized type with type parameters as type arguments, then we consider all
these type parameters if they were all dynamic. Unfortunately
StrongTypeSystemImpl.instantiateToBounds() does not do this - it works only for
types which are not bounds of type parameters.

I added explicit TypeSystem.instantiateToDynamic() and call it now for the
current typeSystem.

   }
 
   /**