Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2376213002:
Remove ante-MD code in ui/views/tabs/tab_strip.cc (Closed)
|
Created:
4 years, 2 months ago by Evan Stade Modified:
4 years, 2 months ago CC:
chromium-reviews, tfarina, oshima+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove ante-MD code in ui/views/tabs/tab_strip.cc
BUG=648281
TBR=oshima@chromium.org
Committed: https://crrev.com/6531cc698b65caf88d4255b7007f58ac93bebbf4
Cr-Commit-Position: refs/heads/master@{#421862}
Patch Set 1 #
Total comments: 2
Patch Set 2 : pkasting suggestion #
Total comments: 1
Messages
Total messages: 23 (13 generated)
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
estade@chromium.org changed reviewers: + pkasting@chromium.org
LGTM https://codereview.chromium.org/2376213002/diff/1/chrome/browser/ui/views/tab... File chrome/browser/ui/views/tabs/tab_strip.cc (right): https://codereview.chromium.org/2376213002/diff/1/chrome/browser/ui/views/tab... chrome/browser/ui/views/tabs/tab_strip.cc:513: canvas->DrawPath(fill, paint); Nit: If you add a paint.setLooper(nullptr) call (I think that'll work) after this line, you can hoist lines 476-7 up to the top of the function and then eliminate lines 517-8. Another way to make this hoisting possible would be to copy |paint| into another temp just before this call so setLooper() gets called on that temp instead.
The CQ bit was checked by estade@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkasting@chromium.org Link to the patchset: https://codereview.chromium.org/2376213002/#ps20001 (title: "pkasting suggestion")
https://codereview.chromium.org/2376213002/diff/1/chrome/browser/ui/views/tab... File chrome/browser/ui/views/tabs/tab_strip.cc (right): https://codereview.chromium.org/2376213002/diff/1/chrome/browser/ui/views/tab... chrome/browser/ui/views/tabs/tab_strip.cc:513: canvas->DrawPath(fill, paint); On 2016/09/29 04:18:59, Peter Kasting (busy Sep 29) wrote: > Nit: If you add a paint.setLooper(nullptr) call (I think that'll work) after > this line, you can hoist lines 476-7 up to the top of the function and then > eliminate lines 517-8. > > Another way to make this hoisting possible would be to copy |paint| into another > temp just before this call so setLooper() gets called on that temp instead. Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Remove ante-MD code in ui/views/tabs/tab_strip.cc BUG=648281 ========== to ========== Remove ante-MD code in ui/views/tabs/tab_strip.cc BUG=648281 TBR=oshima@chromium.org ==========
estade@chromium.org changed reviewers: + oshima@chromium.org
tbr oshima for c/a/t
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove ante-MD code in ui/views/tabs/tab_strip.cc BUG=648281 TBR=oshima@chromium.org ========== to ========== Remove ante-MD code in ui/views/tabs/tab_strip.cc BUG=648281 TBR=oshima@chromium.org ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove ante-MD code in ui/views/tabs/tab_strip.cc BUG=648281 TBR=oshima@chromium.org ========== to ========== Remove ante-MD code in ui/views/tabs/tab_strip.cc BUG=648281 TBR=oshima@chromium.org Committed: https://crrev.com/6531cc698b65caf88d4255b7007f58ac93bebbf4 Cr-Commit-Position: refs/heads/master@{#421862} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6531cc698b65caf88d4255b7007f58ac93bebbf4 Cr-Commit-Position: refs/heads/master@{#421862}
Message was sent while issue was closed.
https://codereview.chromium.org/2376213002/diff/20001/chrome/browser/ui/views... File chrome/browser/ui/views/tabs/tab_strip.cc (left): https://codereview.chromium.org/2376213002/diff/20001/chrome/browser/ui/views... chrome/browser/ui/views/tabs/tab_strip.cc:1539: newtab_button_->Paint(context); oops, should not have removed this clause. Fix here: https://codereview.chromium.org/2401423004/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
