Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 2376203003: [Remoting Android] use HelpAndFeedback.launchFeedback to launch the feedback activity (Closed)

Created:
4 years, 2 months ago by Yuwei
Modified:
4 years, 2 months ago
Reviewers:
Lambros
CC:
chromium-reviews, agrieve+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] use HelpAndFeedback.launchFeedback to launch the feedback activity Step 3/4 of separating feedback and help in the navigation menu. BUG=650813 Committed: https://crrev.com/c2ca6de891a0fe550ce2ea9b0392d6b4f6f457f3 Cr-Commit-Position: refs/heads/master@{#422523}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M remoting/android/java/src/org/chromium/chromoting/NavigationMenuAdapter.java View 2 chunks +1 line, -2 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/help/HelpAndFeedback.java View 1 chunk +7 lines, -0 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/help/HelpAndFeedbackBasic.java View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Yuwei
PTAL Note that this CL must be checked in after the internal implementation is checked ...
4 years, 2 months ago (2016-09-29 23:30:05 UTC) #5
Lambros
lgtm
4 years, 2 months ago (2016-10-03 20:38:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376203003/1
4 years, 2 months ago (2016-10-03 20:42:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 20:58:14 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:59:47 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c2ca6de891a0fe550ce2ea9b0392d6b4f6f457f3
Cr-Commit-Position: refs/heads/master@{#422523}

Powered by Google App Engine
This is Rietveld 408576698