Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 23762002: Make WebFileSystemCallbacks not self-destruct (Chrome-side) (Closed)

Created:
7 years, 3 months ago by kinuko
Modified:
7 years, 3 months ago
Reviewers:
tzik
CC:
chromium-reviews, joi+watch-content_chromium.org, tzik+watch_chromium.org, kinuko+watch, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Make WebFileSystemCallbacks not self-destruct It's multi-sided patch, so again it has ugly ifdefs. Corresponding blink patch: https://codereview.chromium.org/23704004/ BUG=257349 TEST=try, both with and without Blink patch Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221710

Patch Set 1 #

Patch Set 2 : updating headers #

Patch Set 3 : Re-add didFail #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -64 lines) Patch
M content/child/fileapi/webfilesystem_impl.h View 3 chunks +32 lines, -19 lines 0 comments Download
M content/child/fileapi/webfilesystem_impl.cc View 1 2 21 chunks +54 lines, -39 lines 0 comments Download
M content/child/fileapi/webfilewriter_base.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/child/fileapi/webfilewriter_base.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/fileapi/webfilewriter_base_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M webkit/common/fileapi/file_system_util.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
kinuko
PTL
7 years, 3 months ago (2013-09-05 11:20:27 UTC) #1
kinuko
On 2013/09/05 11:20:27, kinuko wrote: > PTL Re-added didFail loop in ~WebFileSystemImpl.
7 years, 3 months ago (2013-09-05 13:29:48 UTC) #2
tzik
The change looks good. Is the failing test related to this change?
7 years, 3 months ago (2013-09-06 06:11:03 UTC) #3
kinuko
On 2013/09/06 06:11:03, tzik wrote: > The change looks good. > Is the failing test ...
7 years, 3 months ago (2013-09-06 10:37:21 UTC) #4
tzik
lgtm
7 years, 3 months ago (2013-09-06 11:36:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/23762002/32001
7 years, 3 months ago (2013-09-06 11:51:20 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 14:40:13 UTC) #7
Message was sent while issue was closed.
Change committed as 221710

Powered by Google App Engine
This is Rietveld 408576698