chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc - Issue 2376193006: Disable Ctrl+Shift+P on Chrome OS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

Issue 2376193006: Disable Ctrl+Shift+P on Chrome OS (Closed)

Patch Set: Fix test. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('K') | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | printing/printing_context_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

index e2bbe87609019972df65b6e42b9441be17732d70..0e0ced1e0fa2ab0c48b773c17c1d011f1d79c6f1 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui_browsertest.cc

@@ -56,11 +56,11 @@ IN_PROC_BROWSER_TEST_F(PrintPreviewTest, PrintCommands) {

ASSERT_TRUE(chrome::IsCommandEnabled(browser(), IDC_PRINT));

-#if defined(ENABLE_BASIC_PRINTING)

+#if defined(ENABLE_BASIC_PRINTING) && !defined(OS_CHROMEOS)

bool is_basic_print_expected = true;

#else

bool is_basic_print_expected = false;

-#endif // ENABLE_BASIC_PRINTING

+#endif // ENABLE_BASIC_PRINTING && !OS_CHROMEOS

Lei Zhang 2016/10/03 23:03:58 omit

skau 2016/10/03 23:32:13 Done.

ASSERT_EQ(is_basic_print_expected,

chrome::IsCommandEnabled(browser(), IDC_BASIC_PRINT));