Disable Ctrl+Shift+P on Chrome OS

chrome/browser/ui/webui/print_preview/print_preview_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview/print_preview_handler.h"
 
 #include <ctype.h>
 #include <stddef.h>
 
 #include <map>
@@ skipping 591 matching lines @@
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("getPreview",
       base::Bind(&PrintPreviewHandler::HandleGetPreview,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("print",
       base::Bind(&PrintPreviewHandler::HandlePrint,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("getPrinterCapabilities",
       base::Bind(&PrintPreviewHandler::HandleGetPrinterCapabilities,
                  base::Unretained(this)));
-#if defined(ENABLE_BASIC_PRINTING)
+#if defined(ENABLE_BASIC_PRINTING) && !defined(OS_CHROMEOS)
   web_ui()->RegisterMessageCallback("showSystemDialog",
       base::Bind(&PrintPreviewHandler::HandleShowSystemDialog,
                  base::Unretained(this)));
-#endif  // ENABLE_BASIC_PRINTING
+#endif  // ENABLE_BASIC_PRINTING && !OS_CHROMEOS

[Lei Zhang, 2016/10/03 23:03:58]

omit?

[skau, 2016/10/03 23:32:13]

Done.

   web_ui()->RegisterMessageCallback("signIn",
       base::Bind(&PrintPreviewHandler::HandleSignin,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("getAccessToken",
       base::Bind(&PrintPreviewHandler::HandleGetAccessToken,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("manageCloudPrinters",
       base::Bind(&PrintPreviewHandler::HandleManageCloudPrint,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("manageLocalPrinters",
@@ skipping 511 matching lines @@
   if (!args->GetString(0, &user))
     return;
   if (!user.empty())
     manage_url = net::AppendQueryParameter(manage_url, "user", user);
   preview_web_contents()->OpenURL(
       content::OpenURLParams(manage_url, content::Referrer(),
                              WindowOpenDisposition::NEW_FOREGROUND_TAB,
                              ui::PAGE_TRANSITION_LINK, false));
 }
 
-#if defined(ENABLE_BASIC_PRINTING)
+#if defined(ENABLE_BASIC_PRINTING) && !defined(OS_CHROMEOS)
 void PrintPreviewHandler::HandleShowSystemDialog(
     const base::ListValue* /*args*/) {
   ReportStats();
   ReportUserActionHistogram(FALLBACK_TO_ADVANCED_SETTINGS_DIALOG);
 
   WebContents* initiator = GetInitiator();
   if (!initiator)
     return;
 
   printing::PrintViewManager* print_view_manager =
       printing::PrintViewManager::FromWebContents(initiator);
   print_view_manager->PrintForSystemDialogNow(
       base::Bind(&PrintPreviewHandler::ClosePreviewDialog,
                  weak_factory_.GetWeakPtr()));
 
   // Cancel the pending preview request if exists.
   print_preview_ui()->OnCancelPendingPreviewRequest();
 }
-#endif  // ENABLE_BASIC_PRINTING
+#endif  // ENABLE_BASIC_PRINTING && !OS_CHROMEOS

[Lei Zhang, 2016/10/03 23:03:58]

omit?

[skau, 2016/10/03 23:32:13]

This is a little far from the if.  I'm going to leave it.

 
 void PrintPreviewHandler::HandleManagePrinters(
     const base::ListValue* /*args*/) {
   ++manage_printers_dialog_request_count_;
 #if defined(OS_CHROMEOS)
   GURL local_printers_manage_url(chrome::kChromeUIMdCupsSettingsURL);
   preview_web_contents()->OpenURL(
       content::OpenURLParams(local_printers_manage_url, content::Referrer(),
                              WindowOpenDisposition::NEW_FOREGROUND_TAB,
                              ui::PAGE_TRANSITION_LINK, false));
@@ skipping 226 matching lines @@
   FileSelected(path, 0, nullptr);
 }
 
 void PrintPreviewHandler::OnPrintPreviewFailed() {
   if (reported_failed_preview_)
     return;
   reported_failed_preview_ = true;
   ReportUserActionHistogram(PREVIEW_FAILED);
 }
 
-#if defined(ENABLE_BASIC_PRINTING)
+#if defined(ENABLE_BASIC_PRINTING) && !defined(OS_CHROMEOS)
 void PrintPreviewHandler::ShowSystemDialog() {
   HandleShowSystemDialog(NULL);
 }
-#endif  // ENABLE_BASIC_PRINTING
+#endif  // ENABLE_BASIC_PRINTING && !OS_CHROMEOS

[Lei Zhang, 2016/10/03 23:03:58]

omit?

[skau, 2016/10/03 23:32:13]

Done.

 
 void PrintPreviewHandler::FileSelected(const base::FilePath& path,
                                        int /* index */,
                                        void* /* params */) {
   // Update downloads location and save sticky settings.
   DownloadPrefs* download_prefs = DownloadPrefs::FromBrowserContext(
       preview_web_contents()->GetBrowserContext());
   download_prefs->SetSaveFilePath(path.DirName());
   printing::StickySettings* sticky_settings = GetStickySettings();
   sticky_settings->SaveInPrefs(
@@ skipping 337 matching lines @@
 
 void PrintPreviewHandler::UnregisterForGaiaCookieChanges() {
   if (gaia_cookie_manager_service_)
     gaia_cookie_manager_service_->RemoveObserver(this);
 }
 
 void PrintPreviewHandler::SetPdfSavedClosureForTesting(
     const base::Closure& closure) {
   pdf_file_saved_closure_ = closure;
 }