Disable Ctrl+Shift+P on Chrome OS

chrome/browser/ui/browser_commands.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_commands.h"
 
 #include "base/command_line.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "build/build_config.h"
@@ skipping 234 matching lines @@
 
   // TODO(gbillock): This is currently called in production by the CanPrint
   // method, and may be too restrictive if we allow print preview to overlap.
   // Re-assess how to queue print preview after we know more about popup
   // management policy.
   const web_modal::WebContentsModalDialogManager* manager =
       web_modal::WebContentsModalDialogManager::FromWebContents(web_contents);
   return manager && manager->IsDialogActive();
 }
 
-#if defined(ENABLE_BASIC_PRINTING)
+#if defined(ENABLE_BASIC_PRINTING) && !defined(OS_CHROMEOS)
 bool PrintPreviewShowing(const Browser* browser) {
 #if defined(ENABLE_PRINT_PREVIEW)
   WebContents* contents = browser->tab_strip_model()->GetActiveWebContents();
   printing::PrintPreviewDialogController* controller =
       printing::PrintPreviewDialogController::GetInstance();
   return controller && (controller->GetPrintPreviewForContents(contents) ||
                         controller->is_creating_print_preview_dialog());
 #else
   return false;
 #endif
 }
-#endif  // ENABLE_BASIC_PRINTING
+#endif  // ENABLE_BASIC_PRINTING && !OS_CHROMEOS

[Lei Zhang, 2016/10/03 23:03:58]

While we are here, can you change this to:

#endif  // defined(ENABLE_BASIC_PRINTING) && !defined(OS_CHROMEOS)

so it matches the #if ?

[skau, 2016/10/03 23:32:13]

Done.

 
 }  // namespace
 
 bool IsCommandEnabled(Browser* browser, int command) {
   return browser->command_controller()->command_updater()->IsCommandEnabled(
       command);
 }
 
 bool SupportsCommand(Browser* browser, int command) {
   return browser->command_controller()->command_updater()->SupportsCommand(
@@ skipping 616 matching lines @@
       !(IsShowingWebContentsModalDialog(browser) ||
         GetContentRestrictions(browser) & CONTENT_RESTRICTION_PRINT);
 }
 
 #if defined(ENABLE_BASIC_PRINTING)
 void BasicPrint(Browser* browser) {
   printing::StartBasicPrint(browser->tab_strip_model()->GetActiveWebContents());
 }
 
 bool CanBasicPrint(Browser* browser) {
+#if defined(OS_CHROMEOS)
+  return false;  // ChromeOS does not use the system print dialog.
+#else
   // If printing is not disabled via pref or policy, it is always possible to
   // advanced print when the print preview is visible.
   return browser->profile()->GetPrefs()->GetBoolean(prefs::kPrintingEnabled) &&
       (PrintPreviewShowing(browser) || CanPrint(browser));
+#endif  // OS_CHROMEOS

[Lei Zhang, 2016/10/03 23:03:58]

Ditto.

[skau, 2016/10/03 23:32:13]

Done.

 }
 #endif  // ENABLE_BASIC_PRINTING
 
 bool CanRouteMedia(Browser* browser) {
   // Do not allow user to open Media Router dialog when there is already an
   // active modal dialog. This avoids overlapping dialogs.
   return media_router::MediaRouterEnabled(browser->profile()) &&
          !IsShowingWebContentsModalDialog(browser);
 }
 
@@ skipping 374 matching lines @@
       app_name, true /* trusted_source */, gfx::Rect(), browser->profile()));
   app_browser->tab_strip_model()->AppendWebContents(contents, true);
 
   contents->GetMutableRendererPrefs()->can_accept_load_drops = false;
   contents->GetRenderViewHost()->SyncRendererPrefs();
   app_browser->window()->Show();
 }
 #endif  // defined(ENABLE_EXTENSIONS)
 
 }  // namespace chrome