Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2376193005: Revert of Fail gracefully if no Chrome trace or insufficient power samples. (Closed)

Created:
4 years, 2 months ago by rnephew (Reviews Here)
Modified:
4 years, 2 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Fail gracefully if no Chrome trace or insufficient power samples. (patchset #8 id:140001 of https://codereview.chromium.org/2371873002/ ) Reason for revert: crbug.com/650306 Causing BattOr tests to fail with: MapFunctionError: Cannot read property 'bounds' of undefined Original issue's description: > Fail gracefully if no Chrome trace or insufficient power samples. > > If there is no Chrome trace available or power samples do not cover > the entire region, return no metrics rather than crashing or > returning bogus metric values. > > BUG=catapult:#2867 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/5c9f7723faa3ba50ff48094ae5dd4d00cfaaad1a TBR=benjhayden@chromium.org,eakuefner@chromium.org,nednguyen@google.com,alexandermont@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2867 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4a9b8db369bd30aa0d4b38461ac92d8acf9b1849

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -415 lines) Patch
M tracing/tracing/metrics/system_health/power_metric.html View 7 chunks +22 lines, -67 lines 0 comments Download
M tracing/tracing/metrics/system_health/power_metric_test.html View 10 chunks +116 lines, -348 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rnephew (Reviews Here)
Created Revert of Fail gracefully if no Chrome trace or insufficient power samples.
4 years, 2 months ago (2016-09-30 15:51:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376193005/1
4 years, 2 months ago (2016-09-30 15:51:29 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 15:51:41 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698