Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: third_party/WebKit/Source/modules/fetch/ResponseTest.cpp

Issue 2376193004: Stop FetchDataLoaderTest from using [Web|Fetch]DataConsumerHandle. (Closed)
Patch Set: fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FormDataBytesConsumerTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/fetch/Response.h" 5 #include "modules/fetch/Response.h"
6 6
7 #include "bindings/core/v8/ExceptionState.h" 7 #include "bindings/core/v8/ExceptionState.h"
8 #include "bindings/core/v8/ScriptState.h" 8 #include "bindings/core/v8/ScriptState.h"
9 #include "bindings/core/v8/V8BindingForTesting.h" 9 #include "bindings/core/v8/V8BindingForTesting.h"
10 #include "core/dom/Document.h" 10 #include "core/dom/Document.h"
11 #include "core/frame/Frame.h" 11 #include "core/frame/Frame.h"
12 #include "core/testing/DummyPageHolder.h" 12 #include "core/testing/DummyPageHolder.h"
13 #include "modules/fetch/BodyStreamBuffer.h" 13 #include "modules/fetch/BodyStreamBuffer.h"
14 #include "modules/fetch/BytesConsumerTestUtil.h"
14 #include "modules/fetch/DataConsumerHandleTestUtil.h" 15 #include "modules/fetch/DataConsumerHandleTestUtil.h"
15 #include "modules/fetch/DataConsumerHandleUtil.h" 16 #include "modules/fetch/DataConsumerHandleUtil.h"
16 #include "modules/fetch/FetchResponseData.h" 17 #include "modules/fetch/FetchResponseData.h"
17 #include "platform/blob/BlobData.h" 18 #include "platform/blob/BlobData.h"
18 #include "platform/testing/UnitTestHelpers.h" 19 #include "platform/testing/UnitTestHelpers.h"
19 #include "public/platform/modules/serviceworker/WebServiceWorkerResponse.h" 20 #include "public/platform/modules/serviceworker/WebServiceWorkerResponse.h"
20 #include "testing/gtest/include/gtest/gtest.h" 21 #include "testing/gtest/include/gtest/gtest.h"
21 #include "wtf/PtrUtil.h" 22 #include "wtf/PtrUtil.h"
22 #include <memory> 23 #include <memory>
23 24
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
163 EXPECT_NE(response->internalBodyBuffer(), originalInternal); 164 EXPECT_NE(response->internalBodyBuffer(), originalInternal);
164 EXPECT_NE(clonedResponse->internalBodyBuffer(), originalInternal); 165 EXPECT_NE(clonedResponse->internalBodyBuffer(), originalInternal);
165 EXPECT_NE(response->internalBodyBuffer(), clonedResponse->internalBodyBuffer ()); 166 EXPECT_NE(response->internalBodyBuffer(), clonedResponse->internalBodyBuffer ());
166 if (checkResponseBodyStreamBuffer) { 167 if (checkResponseBodyStreamBuffer) {
167 EXPECT_EQ(response->bodyBuffer(), response->internalBodyBuffer()); 168 EXPECT_EQ(response->bodyBuffer(), response->internalBodyBuffer());
168 EXPECT_EQ(clonedResponse->bodyBuffer(), clonedResponse->internalBodyBuff er()); 169 EXPECT_EQ(clonedResponse->bodyBuffer(), clonedResponse->internalBodyBuff er());
169 } else { 170 } else {
170 EXPECT_FALSE(response->bodyBuffer()); 171 EXPECT_FALSE(response->bodyBuffer());
171 EXPECT_FALSE(clonedResponse->bodyBuffer()); 172 EXPECT_FALSE(clonedResponse->bodyBuffer());
172 } 173 }
173 DataConsumerHandleTestUtil::MockFetchDataLoaderClient* client1 = new DataCon sumerHandleTestUtil::MockFetchDataLoaderClient(); 174 BytesConsumerTestUtil::MockFetchDataLoaderClient* client1 = new BytesConsume rTestUtil::MockFetchDataLoaderClient();
174 DataConsumerHandleTestUtil::MockFetchDataLoaderClient* client2 = new DataCon sumerHandleTestUtil::MockFetchDataLoaderClient(); 175 BytesConsumerTestUtil::MockFetchDataLoaderClient* client2 = new BytesConsume rTestUtil::MockFetchDataLoaderClient();
175 EXPECT_CALL(*client1, didFetchDataLoadedString(String("Hello, world"))); 176 EXPECT_CALL(*client1, didFetchDataLoadedString(String("Hello, world")));
176 EXPECT_CALL(*client2, didFetchDataLoadedString(String("Hello, world"))); 177 EXPECT_CALL(*client2, didFetchDataLoadedString(String("Hello, world")));
177 178
178 response->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAs String(), client1); 179 response->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAs String(), client1);
179 clonedResponse->internalBodyBuffer()->startLoading(FetchDataLoader::createLo aderAsString(), client2); 180 clonedResponse->internalBodyBuffer()->startLoading(FetchDataLoader::createLo aderAsString(), client2);
180 blink::testing::runPendingTasks(); 181 blink::testing::runPendingTasks();
181 } 182 }
182 183
183 BodyStreamBuffer* createHelloWorldBuffer(ScriptState* scriptState) 184 BodyStreamBuffer* createHelloWorldBuffer(ScriptState* scriptState)
184 { 185 {
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 { 242 {
242 V8TestingScope scope; 243 V8TestingScope scope;
243 BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), crea teFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle() )); 244 BodyStreamBuffer* buffer = new BodyStreamBuffer(scope.getScriptState(), crea teFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle() ));
244 FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(b uffer); 245 FetchResponseData* fetchResponseData = FetchResponseData::createWithBuffer(b uffer);
245 fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com")); 246 fetchResponseData->setURL(KURL(ParsedURLString, "http://www.response.com"));
246 Response* response = Response::create(scope.getExecutionContext(), fetchResp onseData); 247 Response* response = Response::create(scope.getExecutionContext(), fetchResp onseData);
247 TrackExceptionState exceptionState; 248 TrackExceptionState exceptionState;
248 Response* clonedResponse = response->clone(scope.getScriptState(), exception State); 249 Response* clonedResponse = response->clone(scope.getScriptState(), exception State);
249 EXPECT_FALSE(exceptionState.hadException()); 250 EXPECT_FALSE(exceptionState.hadException());
250 251
251 DataConsumerHandleTestUtil::MockFetchDataLoaderClient* client1 = new DataCon sumerHandleTestUtil::MockFetchDataLoaderClient(); 252 BytesConsumerTestUtil::MockFetchDataLoaderClient* client1 = new BytesConsume rTestUtil::MockFetchDataLoaderClient();
252 DataConsumerHandleTestUtil::MockFetchDataLoaderClient* client2 = new DataCon sumerHandleTestUtil::MockFetchDataLoaderClient(); 253 BytesConsumerTestUtil::MockFetchDataLoaderClient* client2 = new BytesConsume rTestUtil::MockFetchDataLoaderClient();
253 EXPECT_CALL(*client1, didFetchDataLoadFailed()); 254 EXPECT_CALL(*client1, didFetchDataLoadFailed());
254 EXPECT_CALL(*client2, didFetchDataLoadFailed()); 255 EXPECT_CALL(*client2, didFetchDataLoadFailed());
255 256
256 response->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAs String(), client1); 257 response->internalBodyBuffer()->startLoading(FetchDataLoader::createLoaderAs String(), client1);
257 clonedResponse->internalBodyBuffer()->startLoading(FetchDataLoader::createLo aderAsString(), client2); 258 clonedResponse->internalBodyBuffer()->startLoading(FetchDataLoader::createLo aderAsString(), client2);
258 blink::testing::runPendingTasks(); 259 blink::testing::runPendingTasks();
259 } 260 }
260 261
261 } // namespace 262 } // namespace
262 } // namespace blink 263 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FormDataBytesConsumerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698