Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2376193002: Fix leaks in CFieldTree::Node. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Fix leaks in CFieldTree::Node. Correctly account for non-leaf Nodes that have CPDF_FormField pointers. Committed: https://pdfium.googlesource.com/pdfium/+/5ef75ba52b1ce6024d6aa43b03e25824a04b469b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M core/fpdfdoc/cpdf_interform.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Lei Zhang
4 years, 2 months ago (2016-09-28 23:13:46 UTC) #6
Tom Sepez
lgtm
4 years, 2 months ago (2016-09-28 23:48:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376193002/1
4 years, 2 months ago (2016-09-28 23:52:57 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 23:53:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/5ef75ba52b1ce6024d6aa43b03e25824a04b...

Powered by Google App Engine
This is Rietveld 408576698