Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1215)

Unified Diff: test/mjsunit/wasm/grow-memory.js

Issue 2376153003: [wasm] Remove improper assembler check for grow memory. (Closed)
Patch Set: Remove --expose-gc from grow-memory.js Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/assembler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/wasm/grow-memory.js
diff --git a/test/mjsunit/wasm/grow-memory.js b/test/mjsunit/wasm/grow-memory.js
index ecc105ee0d1d589f85f08689446c8791a5b8cfe9..e94c8ec575e2295ed7d9f33aef08bcc3537e0e27 100644
--- a/test/mjsunit/wasm/grow-memory.js
+++ b/test/mjsunit/wasm/grow-memory.js
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// Flags: --expose-wasm --expose-gc --stress-compaction
+// Flags: --expose-wasm --stress-compaction
load("test/mjsunit/wasm/wasm-constants.js");
load("test/mjsunit/wasm/wasm-module-builder.js");
@@ -358,3 +358,27 @@ function testGrowMemoryOutOfBoundsOffset() {
}
testGrowMemoryOutOfBoundsOffset();
+
+
+function testGrowMemoryOutOfBoundsOffset2() {
+ var builder = new WasmModuleBuilder();
+ builder.addMemory(16, 128, false);
+ builder.addFunction("main", kSig_v_v)
+ .addBody([
+ kExprI32Const, 20,
+ kExprI32Const, 29,
+ kExprGrowMemory,
+ kExprI32StoreMem, 0, 0xFF, 0xFF, 0xFF, 0x3a
+ ])
+ .exportAs("main");
+
+ var module = builder.instantiate();
+ try {
+ module.exports.main();
+ assertFalse(true);
+ } catch (e) {
+ // should throw OOB
+ }
+}
+
+testGrowMemoryOutOfBoundsOffset2();
« no previous file with comments | « src/assembler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698