Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2376153003: [wasm] Remove improper assembler check for grow memory. (Closed)

Created:
4 years, 2 months ago by titzer
Modified:
4 years, 2 months ago
Reviewers:
gdeepti
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove improper assembler check for grow memory. Note that the offset can still be out of bounds, even after grow memory. The calculation of the remaining size can overflow. R=gdeepti@chromium.org BUG=chromium:644670 Committed: https://crrev.com/e6071a9c067e07304329250e040b652fb82e9b5e Cr-Commit-Position: refs/heads/master@{#39886}

Patch Set 1 #

Patch Set 2 : Remove --expose-gc from grow-memory.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M src/assembler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/wasm/grow-memory.js View 1 2 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
titzer
4 years, 2 months ago (2016-09-29 11:58:52 UTC) #1
gdeepti
lgtm
4 years, 2 months ago (2016-09-29 16:31:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376153003/20001
4 years, 2 months ago (2016-09-29 16:38:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 18:03:53 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e6071a9c067e07304329250e040b652fb82e9b5e Cr-Commit-Position: refs/heads/master@{#39886}
4 years, 2 months ago (2016-09-29 18:04:07 UTC) #15
Michael Achenbach
Please fix the extra test or skip it for now. Fails on linux debug and ...
4 years, 2 months ago (2016-09-29 19:08:02 UTC) #16
adamk
4 years, 2 months ago (2016-09-29 21:54:17 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2378973003/ by adamk@chromium.org.

The reason for reverting is: grow-memory test now fails on Linux dbg, blocking
the CQ:

https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds...



.

Powered by Google App Engine
This is Rietveld 408576698