Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2376143002: [inspector] fix crash in wrapping result for async Runtime.evaluate (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman, alph
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] fix crash in wrapping result for async Runtime.evaluate BUG=chromium:651211, chromium:650965 R=dgozman@chromium.org Committed: https://crrev.com/28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2 Cr-Commit-Position: refs/heads/master@{#39844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M src/inspector/v8-runtime-agent-impl.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
kozy
Dmitry, please take a look. Test is here: https://codereview.chromium.org/2381693002/
4 years, 2 months ago (2016-09-28 21:17:15 UTC) #1
dgozman
lgtm Do we have this bug in M54? Let's merge if so.
4 years, 2 months ago (2016-09-28 23:14:30 UTC) #3
kozy
Alexey, please take a look! I need committer lgtm.
4 years, 2 months ago (2016-09-28 23:19:05 UTC) #5
alph
lgtm
4 years, 2 months ago (2016-09-29 00:05:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376143002/1
4 years, 2 months ago (2016-09-29 00:07:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 00:32:39 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 00:33:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/28fe488fb7bb4b39736595c2ef8aaf8e6a7b22d2
Cr-Commit-Position: refs/heads/master@{#39844}

Powered by Google App Engine
This is Rietveld 408576698