Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2376123005: Provide TaskRunner to ContextCacheController (Closed)

Created:
4 years, 2 months ago by ericrk
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Provide TaskRunner to ContextCacheController Both ContextCacheController and the CommandBuffer/GpuControl need access to a TaskRunner. CommandBuffer/GpuControl currently creates this TaskRunner internally in most cases. This change moves TaskRunner creation to the ContextProvider, allowing the same TaskRunner to be passed to both objects. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2286873003 Cr-Commit-Position: refs/heads/master@{#419553} (cherry picked from commit d989e6a0815a6f77d3a6fbab24afe9ff6abbf25e) BUG=624630 Committed: https://chromium.googlesource.com/chromium/src/+/c7bc434acf21c0330022455bb9f584c764991567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -74 lines) Patch
M android_webview/browser/aw_render_thread_context_provider.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/output/context_cache_controller.h View 3 chunks +9 lines, -1 line 0 comments Download
M cc/output/context_cache_controller.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/output/context_cache_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/raster/raster_buffer_provider_perftest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/test_context_provider.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/test/test_in_process_context_provider.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/test_in_process_context_provider.cc View 3 chunks +14 lines, -10 lines 0 comments Download
M components/display_compositor/gl_helper_benchmark.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/display_compositor/gl_helper_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M components/display_compositor/yuv_readback_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/gpu/client/context_provider_command_buffer.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gl_in_process_context.cc View 7 chunks +21 lines, -20 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M gpu/ipc/client/gpu_in_process_context_tests.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/ui/demo/bitmap_uploader.cc View 2 chunks +3 lines, -1 line 0 comments Download
M services/ui/public/cpp/context_provider.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M services/ui/public/cpp/gles2_context.h View 1 chunk +4 lines, -2 lines 0 comments Download
M services/ui/public/cpp/gles2_context.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M services/ui/surfaces/surfaces_context_provider.h View 2 chunks +5 lines, -0 lines 0 comments Download
M services/ui/surfaces/surfaces_context_provider.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M ui/compositor/test/in_process_context_provider.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ericrk
4 years, 2 months ago (2016-09-29 22:15:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7bc434acf21c0330022455bb9f584c764991567.

Powered by Google App Engine
This is Rietveld 408576698