Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issue 2376123004: Rearrange iOS SetupMetricsAndFieldTrials to SetupFieldTrials and SetupMetrics (Closed)

Created:
4 years, 2 months ago by robliao
Modified:
4 years, 2 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org, gab, fdoray
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rearrange iOS SetupMetricsAndFieldTrials to SetupFieldTrials and SetupMetrics This allows for the Browser Task Scheduler to setup and redirect after SetupFieldTrials to get variations data but before SetupMetrics, which posts tasks to the blocking pool. This harmonizes iOS with https://codereview.chromium.org/2342993002/ BUG=636518 Committed: https://crrev.com/d38f6b0adcf6426b83dfc8bf544bdeedab23521a Cr-Commit-Position: refs/heads/master@{#422890}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M ios/chrome/browser/ios_chrome_field_trials.h View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ios_chrome_field_trials.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.h View 1 chunk +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 5 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
robliao
sdefresne: Please review this CL. Thanks!
4 years, 2 months ago (2016-09-29 22:54:01 UTC) #7
sdefresne
lgtm
4 years, 2 months ago (2016-10-04 11:04:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2376123004/1
4 years, 2 months ago (2016-10-04 19:39:47 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 19:45:51 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 19:49:40 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d38f6b0adcf6426b83dfc8bf544bdeedab23521a
Cr-Commit-Position: refs/heads/master@{#422890}

Powered by Google App Engine
This is Rietveld 408576698